Sharing shell_util_unittest code to verify shortcuts

chrome/installer/util/shell_util.h

Index: chrome/installer/util/shell_util.h
===================================================================
--- chrome/installer/util/shell_util.h	(revision 150342)
+++ chrome/installer/util/shell_util.h	(working copy)
@@ -35,6 +35,14 @@
     SYSTEM_LEVEL = 0x2   // Make any shell changes only at the system level
   };
 
+  enum VerifyShortcuts {

[gab, 2012/08/09 19:25:57]

nit: Rename this to VerifyShortcutStatus to be more explicit about this type.

[Halli, 2012/08/09 20:49:59]

Done.

+    VERIFY_SHORTCUT_SUCCESS,

[gab, 2012/08/09 19:25:57]

nit: Set this first enum to 0 explicitly as per chromium-style (e.g. as in
shell_util.cc:55)

[Halli, 2012/08/09 20:49:59]

Done.

+    VERIFY_SHORTCUT_FAILURE_UNEXPECTED,
+    VERIFY_SHORTCUT_FAILURE_PATH,
+    VERIFY_SHORTCUT_FAILURE_DESCRIPTION,
+    VERIFY_SHORTCUT_FAILURE_ICON_INDEX
+  };
+
   // Relative path of the URL Protocol registry entry (prefixed with '\').
   static const wchar_t* kRegURLProtocol;
 
@@ -412,6 +420,16 @@
                                    int icon_index,
                                    uint32 options);
 
+  // Verify that a shortcut exists with the expected information.
+  // |exe_path| The shortcut's exe.
+  // |shortcut| The path to shortcut.

[gab, 2012/08/09 19:25:57]

+"the" after "to"

[Halli, 2012/08/09 20:49:59]

Done.

+  // |description| The shortcut's description.
+  // |icon_index| The icon's index in the exe.
+  static VerifyShortcuts VerifyChromeShortcut(const string16& exe_path,
+                                              const string16& shortcut,
+                                              const string16& description,
+                                              int icon_index);
+
   // Sets |suffix| to the base 32 encoding of the md5 hash of this user's sid
   // preceded by a dot.
   // This is guaranteed to be unique on the machine and 27 characters long