Sharing shell_util_unittest code to verify shortcuts

chrome/installer/util/shell_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file declares methods that are useful for integrating Chrome in
 // Windows shell. These methods are all static and currently part of
 // ShellUtil class.
 
 #ifndef CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
 #define CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
@@ skipping 424 matching lines @@
   // should call GetCurrentInstallationSuffix().
   static bool GetOldUserSpecificRegistrySuffix(string16* suffix);
 
   // Returns the base32 encoding (using the [A-Z2-7] alphabet) of |bytes|.
   // |size| is the length of |bytes|.
   // Note: This method does not suffix the output with '=' signs as technically
   // required by the base32 standard for inputs that aren't a multiple of 5
   // bytes.
   static string16 ByteArrayToBase32(const uint8* bytes, size_t size);
 
+  // Verify that a shortcut exists with expected information.

[gab, 2012/08/08 16:24:27]

add "the" after "with"

[Halli, 2012/08/08 18:59:13]

Done.

+  // |exe_path| shortcut's exe
+  // |shortcut| path to shortcut
+  // |description| shortcut's description
+  // |icon_index| in the exe

[gab, 2012/08/08 16:24:27]

Please make the definition of |icon_index| "The icon's index in the exe.", i.e.
the variable name shouldn't be considered part of the description sentence :).

[Halli, 2012/08/08 18:59:13]

Done.

+  static bool VerifyChromeShortcut(const string16& exe_path,
+                                   const string16& shortcut,
+                                   const string16& description,
+                                   int icon_index);
  private:
   DISALLOW_COPY_AND_ASSIGN(ShellUtil);
 };
 
 
 #endif  // CHROME_INSTALLER_UTIL_SHELL_UTIL_H_