GDB: Test that we can step inside function.

GDB: Test that we can step inside function.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2947
TEST= run_gdb_step_from_func_start_test
Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9434

[Mark Seaborn, 2012-08-09 00:00:02]

LGTM with the changes below, when this passes.  Also, please make it clearer in
the commit message that this is a GDB test, e.g. by prefixing with "GDB:". 
Plus, mentioning the bug URL twice is redundant - you only need to mention it
once. :-)

http://codereview.chromium.org/10826183/diff/3001/tests/gdb/gdb_test_guest.c
File tests/gdb/gdb_test_guest.c (right):

http://codereview.chromium.org/10826183/diff/3001/tests/gdb/gdb_test_guest.c#...
tests/gdb/gdb_test_guest.c:47: alloca(1);
Please add a comment to explain what calling alloca() does here.

http://codereview.chromium.org/10826183/diff/3001/tests/gdb/gdb_test_guest.c#...
tests/gdb/gdb_test_guest.c:68: if (strcmp(argv[1], "step_from_func_start") == 0)
{
Would it be easier to follow if the entry point name matched the function name?

http://codereview.chromium.org/10826183/diff/3001/tests/gdb/nacl.scons
File tests/gdb/nacl.scons (right):

http://codereview.chromium.org/10826183/diff/3001/tests/gdb/nacl.scons#newcode84
tests/gdb/nacl.scons:84: extra_deps = [sel_ldr, irt, gdb_test_guest])
No spaces around '=' for keyword arguments in Python

[halyavin, 2012-08-09 12:29:20]

https://chromiumcodereview.appspot.com/10826183/diff/3001/tests/gdb/gdb_test_...
File tests/gdb/gdb_test_guest.c (right):

https://chromiumcodereview.appspot.com/10826183/diff/3001/tests/gdb/gdb_test_...
tests/gdb/gdb_test_guest.c:47: alloca(1);
On 2012/08/09 00:00:02, Mark Seaborn wrote:
> Please add a comment to explain what calling alloca() does here.

Done.

https://chromiumcodereview.appspot.com/10826183/diff/3001/tests/gdb/gdb_test_...
tests/gdb/gdb_test_guest.c:68: if (strcmp(argv[1], "step_from_func_start") == 0)
{
On 2012/08/09 00:00:02, Mark Seaborn wrote:
> Would it be easier to follow if the entry point name matched the function
name?

Done.

https://chromiumcodereview.appspot.com/10826183/diff/3001/tests/gdb/nacl.scons
File tests/gdb/nacl.scons (right):

https://chromiumcodereview.appspot.com/10826183/diff/3001/tests/gdb/nacl.scon...
tests/gdb/nacl.scons:84: extra_deps = [sel_ldr, irt, gdb_test_guest])
On 2012/08/09 00:00:02, Mark Seaborn wrote:
> No spaces around '=' for keyword arguments in Python

Done.

[Mark Seaborn, 2012-08-10 14:59:49]

https://chromiumcodereview.appspot.com/10826183/diff/2021/tests/gdb/step_from...
File tests/gdb/step_from_func_start.py (right):

https://chromiumcodereview.appspot.com/10826183/diff/2021/tests/gdb/step_from...
tests/gdb/step_from_func_start.py:15: #assert gdb.Eval('global_var') == '0'
Please don't check in commented-out code like this