Plumb invalidations from Tango to the extensions code for the Push Messaging API.

chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc

Index: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc
diff --git a/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..daa5eeb443ed75a658ede1c9d08961d518ba5dc2
--- /dev/null
+++ b/chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc
@@ -0,0 +1,183 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h"
+
+#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_observer.h"
+#include "chrome/browser/sync/invalidation_service.h"
+#include "google/cacheinvalidation/types.pb.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using ::testing::_;
+using ::testing::NotNull;
+using ::testing::StrictMock;
+
+namespace extensions {
+
+namespace {
+
+class MockInvalidationService : public InvalidationService {
+ public:
+  MockInvalidationService();
+  ~MockInvalidationService();
+  MOCK_METHOD2(UpdateRegisteredInvalidationIds,
+               void(syncer::SyncNotifierObserver*, const syncer::ObjectIdSet&));
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(MockInvalidationService);
+};
+
+MockInvalidationService::MockInvalidationService() {}
+MockInvalidationService::~MockInvalidationService() {}
+
+class MockInvalidationHandlerObserver
+    : public PushMessagingInvalidationHandlerObserver {
+ public:
+  MockInvalidationHandlerObserver();
+  ~MockInvalidationHandlerObserver();
+  MOCK_METHOD3(OnMessage,
+               void(const std::string&, int, const std::string&));
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(MockInvalidationHandlerObserver);
+};
+
+MockInvalidationHandlerObserver::MockInvalidationHandlerObserver() {}
+MockInvalidationHandlerObserver::~MockInvalidationHandlerObserver() {}
+
+class PushMessagingInvalidationHandlerTest : public ::testing::Test {
+ protected:
+  virtual void SetUp() OVERRIDE {
+    EXPECT_CALL(service_,
+                UpdateRegisteredInvalidationIds(NotNull(),
+                                                syncer::ObjectIdSet()));
+    handler_.reset(new PushMessagingInvalidationHandler(
+        &service_, &observer_, std::set<std::string>()));
+  }
+  virtual void TearDown() OVERRIDE {
+    EXPECT_CALL(service_,
+                UpdateRegisteredInvalidationIds(handler_.get(),
+                                                syncer::ObjectIdSet()));
+    handler_.reset();
+  }
+  StrictMock<MockInvalidationService> service_;
+  StrictMock<MockInvalidationHandlerObserver> observer_;
+  scoped_ptr<PushMessagingInvalidationHandler> handler_;
+};
+
+// Tests that we correctly register any extensions passed in when constructed.
+TEST_F(PushMessagingInvalidationHandlerTest, Construction) {
+  TearDown();
+
+  std::set<std::string> extension_ids;
+  extension_ids.insert("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
+  extension_ids.insert("bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb");
+  syncer::ObjectIdSet expected_ids;
+  expected_ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa0"));
+  expected_ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa1"));
+  expected_ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa2"));
+  expected_ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa3"));
+  expected_ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb0"));
+  expected_ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb1"));
+  expected_ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb2"));
+  expected_ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb3"));
+
+  EXPECT_CALL(service_,
+              UpdateRegisteredInvalidationIds(NotNull(), expected_ids));
+  handler_.reset(new PushMessagingInvalidationHandler(
+      &service_, &observer_, extension_ids));
+}
+
+TEST_F(PushMessagingInvalidationHandlerTest, RegisterUnregisterExtension) {
+  syncer::ObjectIdSet expected_ids;
+  expected_ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMcccccccccccccccccccccccccccccccc0"));
+  expected_ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMcccccccccccccccccccccccccccccccc1"));
+  expected_ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMcccccccccccccccccccccccccccccccc2"));
+  expected_ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMcccccccccccccccccccccccccccccccc3"));
+  EXPECT_CALL(service_,
+              UpdateRegisteredInvalidationIds(handler_.get(), expected_ids));
+  handler_->RegisterExtension("cccccccccccccccccccccccccccccccc");
+  EXPECT_CALL(service_,
+              UpdateRegisteredInvalidationIds(handler_.get(),
+                                              syncer::ObjectIdSet()));
+  handler_->UnregisterExtension("cccccccccccccccccccccccccccccccc");
+}
+
+TEST_F(PushMessagingInvalidationHandlerTest, Dispatch) {
+  syncer::ObjectIdSet ids;
+  ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMdddddddddddddddddddddddddddddddd0"));
+  ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMdddddddddddddddddddddddddddddddd3"));
+  EXPECT_CALL(observer_,
+              OnMessage("dddddddddddddddddddddddddddddddd", 0, "payload"));
+  EXPECT_CALL(observer_,
+              OnMessage("dddddddddddddddddddddddddddddddd", 3, "payload"));
+  handler_->OnIncomingNotification(ObjectIdSetToPayloadMap(ids, "payload"),
+                                   syncer::REMOTE_NOTIFICATION);
+}
+
+// Tests that malformed object IDs don't trigger spurious callbacks.
+TEST_F(PushMessagingInvalidationHandlerTest, DispatchInvalidObjectIds) {
+  syncer::ObjectIdSet ids;
+  // Incorrect source.
+  ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::TEST,
+      "UPMdddddddddddddddddddddddddddddddd3"));
+  // Incorrect length.
+  ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPMdddddddddddddddddddddddddddddddd34"));
+  // Incorrect format type.
+  ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "VPMdddddddddddddddddddddddddddddddd3"));
+  // Incorrect project ID.
+  ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPCdddddddddddddddddddddddddddddddd3"));
+  // Non-numeric subchannel.
+  ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPCddddddddddddddddddddddddddddddddz"));
+  // Subchannel out of range.
+  ids.insert(invalidation::ObjectId(
+      ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
+      "UPCdddddddddddddddddddddddddddddddd4"));
+  handler_->OnIncomingNotification(ObjectIdSetToPayloadMap(ids, "payload"),
+                                   syncer::REMOTE_NOTIFICATION);
+}
+
+}  // namespace
+
+}  // namespace extensions