Plumb invalidations from Tango to the extensions code for the Push Messaging API.

chrome/browser/extensions/api/push_messaging/push_messaging_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/push_messaging/push_messaging_api.h"
 
+#include <set>
+
 #include "base/bind.h"
+#include "base/logging.h"
 #include "base/values.h"
+#include "chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h"
 #include "chrome/browser/extensions/event_names.h"
 #include "chrome/browser/extensions/event_router.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/sync/profile_sync_service.h"
+#include "chrome/browser/sync/profile_sync_service_factory.h"
+#include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/api/experimental_push_messaging.h"
-#include "content/public/browser/browser_thread.h"
+#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_set.h"
+#include "chrome/common/extensions/permissions/api_permission.h"
+#include "content/public/browser/notification_details.h"
+#include "content/public/browser/notification_source.h"
 #include "googleurl/src/gurl.h"
 
 namespace extensions {
 
-namespace glue = extensions::api::experimental_push_messaging;
+namespace glue = api::experimental_push_messaging;
 
 PushMessagingEventRouter::PushMessagingEventRouter(Profile* profile)
     : profile_(profile) {
 }
 
 PushMessagingEventRouter::~PushMessagingEventRouter() {}
 

[Pete Williamson, 2012/08/13 18:24:09]

Might be good to add a comment here:
// Find out about all the extensions, both already installed and those that get
installed during this session, put them into a list, and register their
associated object IDs.

[dcheng, 2012/08/13 20:44:14]

In general, we try to avoid comments that describe what the code does.

 void PushMessagingEventRouter::Init() {
-  // TODO(dcheng): Add hooks into InvalidationHandler when landed.
+  ProfileSyncService* pss = ProfileSyncServiceFactory::GetForProfile(profile_);
+  // This may be NULL; for example, for the ChromeOS guest user. In these cases,
+  // just return without setting up anything, since it won't work anyway.
+  if (!pss)
+    return;
+

[Pete Williamson, 2012/08/13 18:24:09]

Might be good to add a comment:
// Register for all extension load and unload events so we can tell when a new
push-messaging capable extension installs or uninstalls

[dcheng, 2012/08/13 20:44:14]

Done.

+  registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED,
+                 content::Source<Profile>(profile_->GetOriginalProfile()));
+  registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED,
+                 content::Source<Profile>(profile_->GetOriginalProfile()));
+  const ExtensionSet* extensions =
+      ExtensionSystem::Get(profile_)->extension_service()->extensions();
+  std::set<std::string> push_messaging_extensions;

[Pete Williamson, 2012/08/13 18:24:09]

// Iterate over the list of installed extensions and make a list of those who
use push-messaging

[dcheng, 2012/08/13 20:44:14]

See above.

+  for (ExtensionSet::const_iterator it = extensions->begin();
+       it != extensions->end(); ++it) {
+    const Extension* extension = *it;
+    if (extension->HasAPIPermission(APIPermission::kPushMessaging)) {
+      push_messaging_extensions.insert(extension->id());
+    }
+  }

[Pete Williamson, 2012/08/13 18:24:09]

//  now register all the object IDs for the push messaging extensions

[dcheng, 2012/08/13 20:44:14]

See above.

+  handler_.reset(new PushMessagingInvalidationHandler(
+      pss, this, push_messaging_extensions));
+}
+
+void PushMessagingEventRouter::Shutdown() {
+  handler_.reset();
+}
+
+void PushMessagingEventRouter::SetMapperForTest(
+    scoped_ptr<PushMessagingInvalidationMapper> mapper) {
+  handler_ = mapper.Pass();
 }
 
 void PushMessagingEventRouter::OnMessage(const std::string& extension_id,
                                          int subchannel,
                                          const std::string& payload) {
   glue::Message message;
   message.subchannel_id = subchannel;
   message.payload = payload;
 
   scoped_ptr<base::ListValue> args(glue::OnMessage::Create(message));
-  profile_->GetExtensionEventRouter()->DispatchEventToExtension(
+  ExtensionSystem::Get(profile_)->event_router()->DispatchEventToExtension(
       extension_id,
       event_names::kOnPushMessage,
       args.Pass(),
       profile_,
       GURL());
 }
 
+void PushMessagingEventRouter::Observe(
+    int type,
+    const content::NotificationSource& source,
+    const content::NotificationDetails& details) {
+  switch (type) {
+    case chrome::NOTIFICATION_EXTENSION_LOADED: {
+      const Extension* extension = content::Details<Extension>(details).ptr();
+      if (extension->HasAPIPermission(APIPermission::kPushMessaging)) {
+        handler_->RegisterExtension(extension->id());
+      }
+      break;
+    }
+    case chrome::NOTIFICATION_EXTENSION_UNLOADED: {

[Mihai Parparita -not on Chrome, 2012/08/11 00:47:27]

There's also NOTIFICATION_EXTENSION_PERMISSIONS_UPDATED (when permissions are
granted via the optional permissions API).

[dcheng, 2012/08/13 20:44:14]

Hmm. Thinking about it more, I'm not sure if push messaging makes a good
optional permission. It seems like something you'd always want on, whereas
optional permission seems to imply that you should drop it as soon as you don't
need it...

+      const Extension* extension =
+          content::Details<UnloadedExtensionInfo>(details)->extension;
+      if (extension->HasAPIPermission(APIPermission::kPushMessaging)) {
+        handler_->UnregisterExtension(extension->id());
+      }
+      break;
+    }
+    default:
+      NOTREACHED();
+  }
+}
+
 }  // namespace extensions