Add frameless for ShellWindow on gtk.

Add frameless for ShellWindow on gtk.

BUG=130182
TEST=manually


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150233

[Junmin Zhu, 2012-08-03 15:19:49]

Please review the patch. Thanks

[Evan Stade, 2012-08-03 17:52:15]

lgtm for gtk

[jeremy, 2012-08-05 08:04:21]

This is a pretty minor change but I think rsesek has reviewed other patches in
this area and has more context, therefore delegating to him.

http://codereview.chromium.org/10826145/diff/1/chrome/browser/ui/cocoa/extens...
File chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm (right):

http://codereview.chromium.org/10826145/diff/1/chrome/browser/ui/cocoa/extens...
chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm:97: // Hide titlebar
when {frame: 'none'} on ShellWindow.
nit: on -> specified on

[jeremya, 2012-08-05 22:16:02]

On 2012/08/05 08:04:21, jeremy wrote:
> This is a pretty minor change but I think rsesek has reviewed other patches in
> this area and has more context, therefore delegating to him.
> 
>
http://codereview.chromium.org/10826145/diff/1/chrome/browser/ui/cocoa/extens...
> File chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm (right):
> 
>
http://codereview.chromium.org/10826145/diff/1/chrome/browser/ui/cocoa/extens...
> chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm:97: // Hide titlebar
> when {frame: 'none'} on ShellWindow.
> nit: on -> specified on

Please don't land the cocoa part of this, as I have
http://codereview.chromium.org/10824004/ to address that (and it's more
complicated than your fix here, particularly regarding fullscreen :))

[Junmin Zhu, 2012-08-06 00:54:24]

On 2012/08/05 22:16:02, jeremya wrote:
> On 2012/08/05 08:04:21, jeremy wrote:
> > This is a pretty minor change but I think rsesek has reviewed other patches
in
> > this area and has more context, therefore delegating to him.
> > 
> >
>
http://codereview.chromium.org/10826145/diff/1/chrome/browser/ui/cocoa/extens...
> > File chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm (right):
> > 
> >
>
http://codereview.chromium.org/10826145/diff/1/chrome/browser/ui/cocoa/extens...
> > chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm:97: // Hide
titlebar
> > when {frame: 'none'} on ShellWindow.
> > nit: on -> specified on
> 
> Please don't land the cocoa part of this, as I have
> http://codereview.chromium.org/10824004/ to address that (and it's more
> complicated than your fix here, particularly regarding fullscreen :))

Bang, conflicted.:)
Update the patch with removing the cocoa part code.
Please help review it.

[commit-bot: I haz the power, 2012-08-06 13:00:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/junmin.zhu@intel.com/10826145/7001

[commit-bot: I haz the power, 2012-08-06 16:24:40]

Try job failure for 10826145-7001 (retry) (retry) (retry) on win_rel for step
"compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-07 00:19:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/junmin.zhu@intel.com/10826145/7001

[commit-bot: I haz the power, 2012-08-07 02:12:14]

Change committed as 150233