chrome/renderer/extensions/extension_helper.cc - Issue 10826141: Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_helper.cc

Issue 10826141: Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: win compile fix Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/extensions/extension_helper.cc

diff --git a/chrome/renderer/extensions/extension_helper.cc b/chrome/renderer/extensions/extension_helper.cc

index ef75d7a474dd5b0b7206d4c25f589e1c681d2245..80695e2b7b39ef79efe269dea0dbc4946e92882d 100644

--- a/chrome/renderer/extensions/extension_helper.cc

+++ b/chrome/renderer/extensions/extension_helper.cc

@@ -345,7 +345,7 @@ void ExtensionHelper::OnExecuteCode(

if (!main_frame) {

ListValue val;

Send(new ExtensionHostMsg_ExecuteCodeFinished(

- routing_id(), params.request_id, false, -1, "", val));

+ routing_id(), params.request_id, "No main frame", -1, GURL(""), val));

return;

}

« no previous file with comments | « chrome/common/extensions/extension_messages.h ('k') | chrome/renderer/extensions/user_script_scheduler.cc » ('j') | no next file with comments »