chrome/browser/extensions/script_badge_controller_unittest.cc - Issue 10826141: Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/script_badge_controller_unittest.cc

Issue 10826141: Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: win compile fix Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/script_badge_controller_unittest.cc

diff --git a/chrome/browser/extensions/script_badge_controller_unittest.cc b/chrome/browser/extensions/script_badge_controller_unittest.cc

index 2e53cd72f0efb2b16a7a6a2c786fd17ef0f039f1..7ed0f23913e244bd495178497884629a9a38fa95 100644

--- a/chrome/browser/extensions/script_badge_controller_unittest.cc

+++ b/chrome/browser/extensions/script_badge_controller_unittest.cc

@@ -120,10 +120,11 @@ TEST_F(ScriptBadgeControllerTest, ExecutionMakesBadgeVisible) {

ListValue val;

script_badge_controller_->OnExecuteScriptFinished(

- extension->id(), true,

+ extension->id(),

+ "", // no error

tab_contents()->web_contents()->GetController().GetActiveEntry()->

GetPageID(),

- "",

+ GURL(""),

val);

EXPECT_THAT(script_badge_controller_->GetCurrentActions(),

testing::ElementsAre(extension->script_badge()));

@@ -147,10 +148,11 @@ TEST_F(ScriptBadgeControllerTest, FragmentNavigation) {