chrome/browser/extensions/api/tabs/execute_code_in_tab_function.h - Issue 10826141: Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/execute_code_in_tab_function.h

Issue 10826141: Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: win compile fix Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/tabs/execute_code_in_tab_function.h

diff --git a/chrome/browser/extensions/api/tabs/execute_code_in_tab_function.h b/chrome/browser/extensions/api/tabs/execute_code_in_tab_function.h

index fa500e1c64ad81af6356dceff471ceb29bf5acf0..7ce5ec1d30b3b72b6ed2ec3ceb79501b58fa6706 100644

--- a/chrome/browser/extensions/api/tabs/execute_code_in_tab_function.h

+++ b/chrome/browser/extensions/api/tabs/execute_code_in_tab_function.h

@@ -32,9 +32,9 @@ class ExecuteCodeInTabFunction : public AsyncExtensionFunction {

virtual bool RunImpl() OVERRIDE;

// Message handler.

- virtual void OnExecuteCodeFinished(bool success,

- int32 page_id,

- const std::string& error,

+ virtual void OnExecuteCodeFinished(const std::string& error,

+ int32 on_page_id,

+ const GURL& on_url,

const ListValue& script_result);

private:

@@ -76,8 +76,9 @@ class TabsExecuteScriptFunction : public ExecuteCodeInTabFunction {

private:

virtual ~TabsExecuteScriptFunction() {}

- virtual void OnExecuteCodeFinished(bool success, int32 page_id,

- const std::string& error,

+ virtual void OnExecuteCodeFinished(const std::string& error,

+ int32 on_page_id,

+ const GURL& on_url,

const ListValue& script_result) OVERRIDE;

DECLARE_EXTENSION_FUNCTION_NAME("tabs.executeScript")

« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc » ('j') | no next file with comments »