Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3007)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/api/tabs/tabs.h

Issue 10826141: Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: add URL parameter Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc ('k') | chrome/browser/extensions/api/tabs/tabs.cc » ('j') | chrome/browser/extensions/script_badge_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tabs/tabs.h
diff --git a/chrome/browser/extensions/api/tabs/tabs.h b/chrome/browser/extensions/api/tabs/tabs.h
index e39f59ac32f6bc7a35353c88ee58e0fb415ebfce..26125ac2244ebe1e2c9b1d4eb55e3d725024722e 100644
--- a/chrome/browser/extensions/api/tabs/tabs.h
+++ b/chrome/browser/extensions/api/tabs/tabs.h
@@ -129,9 +129,9 @@ class UpdateTabFunction : public AsyncExtensionFunction {
private:
virtual bool RunImpl() OVERRIDE;
- void OnExecuteCodeFinished(bool success,
- int32 page_id,
- const std::string& error,
+ void OnExecuteCodeFinished(const std::string& error,
+ int32 on_page_id,
+ const GURL& on_url,
const ListValue& script_result);
DECLARE_EXTENSION_FUNCTION_NAME("tabs.update")
« no previous file with comments | « chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc ('k') | chrome/browser/extensions/api/tabs/tabs.cc » ('j') | chrome/browser/extensions/script_badge_controller.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698