Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Side by Side Diff: chrome/browser/extensions/api/tabs/tabs.h

Issue 10826141: Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: win compile fix Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_H__ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_H__
6 #define CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_H__ 6 #define CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_H__
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 virtual ~UpdateTabFunction() {} 122 virtual ~UpdateTabFunction() {}
123 virtual bool UpdateURLIfPresent(base::DictionaryValue* update_props, 123 virtual bool UpdateURLIfPresent(base::DictionaryValue* update_props,
124 int tab_id, 124 int tab_id,
125 bool* is_async); 125 bool* is_async);
126 virtual void PopulateResult(); 126 virtual void PopulateResult();
127 127
128 TabContents* tab_contents_; 128 TabContents* tab_contents_;
129 129
130 private: 130 private:
131 virtual bool RunImpl() OVERRIDE; 131 virtual bool RunImpl() OVERRIDE;
132 void OnExecuteCodeFinished(bool success, 132 void OnExecuteCodeFinished(const std::string& error,
133 int32 page_id, 133 int32 on_page_id,
134 const std::string& error, 134 const GURL& on_url,
135 const ListValue& script_result); 135 const ListValue& script_result);
136 136
137 DECLARE_EXTENSION_FUNCTION_NAME("tabs.update") 137 DECLARE_EXTENSION_FUNCTION_NAME("tabs.update")
138 }; 138 };
139 class MoveTabsFunction : public SyncExtensionFunction { 139 class MoveTabsFunction : public SyncExtensionFunction {
140 virtual ~MoveTabsFunction() {} 140 virtual ~MoveTabsFunction() {}
141 virtual bool RunImpl() OVERRIDE; 141 virtual bool RunImpl() OVERRIDE;
142 DECLARE_EXTENSION_FUNCTION_NAME("tabs.move") 142 DECLARE_EXTENSION_FUNCTION_NAME("tabs.move")
143 }; 143 };
144 class ReloadTabFunction : public SyncExtensionFunction { 144 class ReloadTabFunction : public SyncExtensionFunction {
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 // The format (JPEG vs PNG) of the resulting image. Set in RunImpl(). 196 // The format (JPEG vs PNG) of the resulting image. Set in RunImpl().
197 ImageFormat image_format_; 197 ImageFormat image_format_;
198 198
199 // Quality setting to use when encoding jpegs. Set in RunImpl(). 199 // Quality setting to use when encoding jpegs. Set in RunImpl().
200 int image_quality_; 200 int image_quality_;
201 201
202 DECLARE_EXTENSION_FUNCTION_NAME("tabs.captureVisibleTab") 202 DECLARE_EXTENSION_FUNCTION_NAME("tabs.captureVisibleTab")
203 }; 203 };
204 204
205 #endif // CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_H__ 205 #endif // CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_H__
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc ('k') | chrome/browser/extensions/api/tabs/tabs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698