Fix memory leak in ~GestureRecognizerImpl

ui/base/gestures/gesture_recognizer_impl.cc

Index: ui/base/gestures/gesture_recognizer_impl.cc
diff --git a/ui/base/gestures/gesture_recognizer_impl.cc b/ui/base/gestures/gesture_recognizer_impl.cc
index 20b88d4a437d7344bf02e38dda8e1e79847132f5..94c3e859104ec176392c2ef5bb565b0f95aa4f13 100644
--- a/ui/base/gestures/gesture_recognizer_impl.cc
+++ b/ui/base/gestures/gesture_recognizer_impl.cc
@@ -170,6 +170,12 @@ GestureRecognizerImpl::GestureRecognizerImpl(GestureEventHelper* helper)
 }
 
 GestureRecognizerImpl::~GestureRecognizerImpl() {
+  std::map<GestureConsumer*, GestureSequence*>::iterator i;
+  for (i = consumer_sequence_.begin(); i != consumer_sequence_.end(); ++i)

[sky, 2012/08/03 20:05:07]

Move iterators inside the for loop, that way you don't end up with i2. That
said, I believe STLDeleteValues does what you want (in base/stl_util.h).

[girard, 2012/08/03 20:14:45]

Nice!  I was hoping there might be a utility to take care of this.

[sadrul, 2012/08/03 20:16:42]

Nice! Thanks!

+    delete i->second;
+  std::map<GestureConsumer*, TouchEventQueue*>::iterator i2;
+  for (i2 = event_queue_.begin(); i2 != event_queue_.end(); ++i2)
+    delete i2->second;
 }
 
 // Checks if this finger is already down, if so, returns the current target.