Optimize away most implicit const getter functions

runtime/vm/object.cc

Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc	(revision 10092)
+++ runtime/vm/object.cc	(working copy)
@@ -1494,9 +1494,6 @@
   for (intptr_t i = 0; i < len; i++) {
     field ^= value.At(i);
     field.set_owner(*this);
-    // Only static const fields may contain the Object::sentinel value.
-    ASSERT(!(field.is_static() && field.is_final()) ||
-           (field.value() == Object::sentinel()));

[regis, 2012/07/31 23:19:54]

Is there any way you can relax this assert rather than delete it?

[hausner, 2012/07/31 23:34:03]

I tried this at first, but it is actually impossible to check what the comment
implies.

What this assert did was check that if a field is static final, the value must
be sentinel. With my change, the value would be sentinel or anything else. Thus,
the assert became pointless.

Reversing the assert so it checks that if the value is sentinel, the field must
be static const does not work because if you reference the value of a non-static
field, you run into another assertion.

   }
   // The value of static fields is already initialized to null.
   StorePointer(&raw_ptr()->fields_, value.raw());