ash/wm/frame_painter.cc - Issue 10826085: Fixing problems with constrained windows (i.e. print preview)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/frame_painter.cc

Issue 10826085: Fixing problems with constrained windows (i.e. print preview) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Added property flag to distinguish constrained windows Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/frame_painter.cc

diff --git a/ash/wm/frame_painter.cc b/ash/wm/frame_painter.cc

index 2c0a43c30a97e3ac3bde5d62c604c4b4a85a9550..647e3a000962ae9e7a6159c94b60354aca496c21 100644

--- a/ash/wm/frame_painter.cc

+++ b/ash/wm/frame_painter.cc

@@ -609,7 +609,10 @@ bool FramePainter::UseSoloWindowHeader() {

for (std::set<FramePainter*>::const_iterator it = instances_->begin();

it != instances_->end();

++it) {

- if (IsVisibleNormalWindow((*it)->window_)) {

+ // The window needs to be a 'normal window'. To exclude constrained windows

+ // the existence of a layout manager gets additionally tested.

+ if (IsVisibleNormalWindow((*it)->window_) &&

+ (!(*it)->window_->GetProperty(aura::client::kConstrainedWindowKey))) {

window_count++;

if (window_count > 1)

return false;