chrome/common/extensions/docs/server2/example_zipper.py - Issue 10826037: Extensions Docs Server: Fix zipper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/example_zipper.py

Issue 10826037: Extensions Docs Server: Fix zipper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: process -> binary Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/docs/server2/example_zipper.py

diff --git a/chrome/common/extensions/docs/server2/example_zipper.py b/chrome/common/extensions/docs/server2/example_zipper.py

index a21867cfd3ecfab9b3442798f2441aaaa9635fe9..26dbe1573f16313e6d0f5889e679cd15fb3515a5 100644

--- a/chrome/common/extensions/docs/server2/example_zipper.py

+++ b/chrome/common/extensions/docs/server2/example_zipper.py

@@ -24,8 +24,9 @@ class ExampleZipper(object):

zip_bytes = BytesIO()

zip_file = ZipFile(zip_bytes, mode='w')

try:

- for filename, contents in self._file_system.Read(files).Get().iteritems():

- zip_file.writestr(filename[len(prefix):].strip('/'), contents)

+ for name, file_contents in (

+ self._file_system.Read(files, binary=True).Get().iteritems()):

+ zip_file.writestr(name[len(prefix):].strip('/'), file_contents)

finally:

zip_file.close()

return zip_bytes.getvalue()