Load static symbol information lazily with some clean-ups.

Load static symbol information lazily with some clean-ups.

It also changes :
- dmprof messages,
- how to run subprocesses in prepare_symbol_info,
- to prepare readelf result in prepare_symbol_info,
- to rename procedure_boundaries => static_symbols,
- how to parse nm results in static_symbols,
- additional --keep option,
- to ignore empty files, and
- to store addresses in int.


BUG=123749
TEST=use dmprof.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148930

[Dai Mikurube (NOT FULLTIME), 2012-07-27 08:04:37]

Hi Marc,

Could you please take a look at this change?  It is almost code clean-up, and
changes to load information lazily (DelayedStaticSymbols).

[M-A Ruel, 2012-07-27 13:38:14]

lgtm with nits

http://codereview.chromium.org/10826008/diff/1006/tools/find_runtime_symbols/...
File tools/find_runtime_symbols/prepare_symbol_info.py (right):

http://codereview.chromium.org/10826008/diff/1006/tools/find_runtime_symbols/...
tools/find_runtime_symbols/prepare_symbol_info.py:24: try:
You should use tempfile.mkstemp() in that case;
handle, name = tempfile.mkstemp(...)
subprocess.check_call(command, stdout=handle, stderr=subprocess.STDOUT)
os.close(handle)

And you should make sure command is a list.

http://codereview.chromium.org/10826008/diff/1006/tools/find_runtime_symbols/...
tools/find_runtime_symbols/prepare_symbol_info.py:85: 'nm -n --format bsd %s |
c++filt' % entry.name,
Please do not use the shell if possible. You can create the pipes yourself.

[Dai Mikurube (NOT FULLTIME), 2012-07-30 04:18:38]

Thank you, Marc.

I am checking the "Commit" box.  If you have additional opinions about this
change, I will fix them in another change asap.

http://codereview.chromium.org/10826008/diff/1006/tools/find_runtime_symbols/...
File tools/find_runtime_symbols/prepare_symbol_info.py (right):

http://codereview.chromium.org/10826008/diff/1006/tools/find_runtime_symbols/...
tools/find_runtime_symbols/prepare_symbol_info.py:24: try:
On 2012/07/27 13:38:14, Marc-Antoine Ruel wrote:
> You should use tempfile.mkstemp() in that case;
> handle, name = tempfile.mkstemp(...)
> subprocess.check_call(command, stdout=handle, stderr=subprocess.STDOUT)
> os.close(handle)
> 
> And you should make sure command is a list.

Done.

http://codereview.chromium.org/10826008/diff/1006/tools/find_runtime_symbols/...
tools/find_runtime_symbols/prepare_symbol_info.py:85: 'nm -n --format bsd %s |
c++filt' % entry.name,
On 2012/07/27 13:38:14, Marc-Antoine Ruel wrote:
> Please do not use the shell if possible. You can create the pipes yourself.

I avoided self-made pipes to avoid subprocess.PIPE locking safely.

[commit-bot: I haz the power, 2012-07-30 04:19:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/10826008/7

[commit-bot: I haz the power, 2012-07-30 06:39:09]

Change committed as 148930