chrome/test/nacl/DEPS - Issue 10825462: Add browser_test to check that NaCl is logging UMA samples correctly.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/nacl/DEPS

Issue 10825462: Add browser_test to check that NaCl is logging UMA samples correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 include_rules = [

	2 # Tests will need access to error codes and similar.

	3 "+native_client",
	Mark Seaborn 2012/08/21 19:41:37 Maybe list the specific header here, i.e. "native_ Maybe list the specific header here, i.e. "native_client/src/trusted/service_runtime/nacl_error_code.h", and add a TODO to clean up this dependency and reference https://code.google.com/p/nativeclient/issues/detail?id=2832. Nick Bray (chromium) 2012/08/24 18:17:48 1) I didn't want to list specific files because th Show quoted text On 2012/08/21 19:41:37, Mark Seaborn wrote: > Maybe list the specific header here, i.e. > "native_client/src/trusted/service_runtime/nacl_error_code.h", > and add a TODO to clean up this dependency and reference > https://code.google.com/p/nativeclient/issues/detail?id=2832. 1) I didn't want to list specific files because this will change. 2) I don't see a cleaner way to do this, so I don't see how it could be cleaned up. Mark Seaborn 2012/08/24 19:30:42 As we discussed, please read the issue I linked, w Show quoted text On 2012/08/24 18:17:48, Nick Bray (chromium) wrote: > On 2012/08/21 19:41:37, Mark Seaborn wrote: > > Maybe list the specific header here, i.e. > > "native_client/src/trusted/service_runtime/nacl_error_code.h", > > and add a TODO to clean up this dependency and reference > > https://code.google.com/p/nativeclient/issues/detail?id=2832. > > 1) I didn't want to list specific files because this will change. > > 2) I don't see a cleaner way to do this, so I don't see how it could be cleaned > up. As we discussed, please read the issue I linked, which explains what I mean. :-) Nick Bray (chromium) 2012/08/24 21:13:56 Done. Show quoted text On 2012/08/24 19:30:42, Mark Seaborn wrote: > On 2012/08/24 18:17:48, Nick Bray (chromium) wrote: > > On 2012/08/21 19:41:37, Mark Seaborn wrote: > > > Maybe list the specific header here, i.e. > > > "native_client/src/trusted/service_runtime/nacl_error_code.h", > > > and add a TODO to clean up this dependency and reference > > > https://code.google.com/p/nativeclient/issues/detail?id=2832. > > > > 1) I didn't want to list specific files because this will change. > > > > 2) I don't see a cleaner way to do this, so I don't see how it could be > cleaned > > up. > > As we discussed, please read the issue I linked, which explains what I mean. :-) Done.
	4 "+ppapi",

	5 ]

OLD	NEW

« no previous file with comments | « no previous file | chrome/test/nacl/nacl_browsertest.cc » ('j') | chrome/test/nacl/nacl_browsertest.cc » ('J')