[Panel refactor] use browserless Panels by default in Dev/Canary

chrome/browser/extensions/api/tabs/tabs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tabs/tabs.h"
 
 #include <algorithm>
 #include <limits>
 #include <vector>
 
@@ skipping 32 matching lines @@
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/extensions/shell_window.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
 #include "chrome/browser/ui/snapshot_tab_helper.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/window_sizer/window_sizer.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/chrome_version_info.h"
 #include "chrome/common/extensions/api/windows.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_error_utils.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/extensions/user_script.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
@@ skipping 505 matching lines @@
         error_ = keys::kInvalidWindowTypeError;
         return false;
       }
     }
   }
 
   if (window_type == Browser::TYPE_PANEL) {
     std::string title =
         web_app::GenerateApplicationNameFromExtensionId(extension_id);
 #if !defined(USE_ASH)
+    chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
     if (CommandLine::ForCurrentProcess()->HasSwitch(
-            switches::kBrowserlessPanels)) {
+            switches::kBrowserlessPanels) ||
+        channel == chrome::VersionInfo::CHANNEL_DEV ||
+        channel == chrome::VersionInfo::CHANNEL_CANARY) {

[Matt Perry, 2012/08/16 20:22:07]

You can use channel <= DEV to cover these cases, as well as "trunk" (which is
CHANNEL_UNKNOWN).

[jennb, 2012/08/16 20:42:50]

I don't want to include CHANNEL_UNKNOWN. That way, we can still debug issues in
our own builds and compare old-style Panels with refactored Panels behavior.

       // Note: Panels ignore all but the first url provided.
       Panel* panel = PanelManager::GetInstance()->CreatePanel(
           title, window_profile, urls[0], panel_bounds.size());
 
       // Unlike other window types, Panels do not take focus by default.
       if (!saw_focus_key || !focused)
         panel->ShowInactive();
       else
         panel->Show();
 
@@ skipping 1230 matching lines @@
   // called for every API call the extension made.
   GotLanguage(language);
 }
 
 void DetectTabLanguageFunction::GotLanguage(const std::string& language) {
   SetResult(Value::CreateStringValue(language.c_str()));
   SendResponse(true);
 
   Release();  // Balanced in Run()
 }