chrome/browser/extensions/app_host/binaries_installer.h - Issue 10825364: Upon execution of the App Host, ask Omaha to install the Chrome Binaries if they are not present on…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/app_host/binaries_installer.h

Issue 10825364: Upon execution of the App Host, ask Omaha to install the Chrome Binaries if they are not present on… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More wood behind fewer return statements. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/app_host/app_host_main.cc ('k') | chrome/browser/extensions/app_host/binaries_installer.cc » ('j') | chrome/browser/extensions/app_host/binaries_installer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_EXTENSIONS_APP_HOST_BINARIES_INSTALLER_H_

	6 #define CHROME_BROWSER_EXTENSIONS_APP_HOST_BINARIES_INSTALLER_H_

	7

	8 #include <windows.h>

	9

	10 namespace app_host {

	11

	12 // Attempts to install the Chrome Binaries. Blocks until the installation

	13 // process is complete. The AP value from the currently installed App Host will

	14 // be used, if any.
	miket_OOO 2012/08/23 23:51:01 It reduces to the same thing in either case, but t It reduces to the same thing in either case, but to reduce ambiguity, can you move "if any" to directly follow the thing it's referring to? (probably AP value) erikwright (departed) 2012/08/31 21:04:48 Done. Show quoted text On 2012/08/23 23:51:01, miket wrote: > It reduces to the same thing in either case, but to reduce ambiguity, can you > move "if any" to directly follow the thing it's referring to? (probably AP > value) Done.
	15 HRESULT InstallBinaries();

	16

	17 } // namespace app_host

	18

	19 #endif // CHROME_BROWSER_EXTENSIONS_APP_HOST_BINARIES_INSTALLER_H_

OLD	NEW