Change picker model API to allow less notification messages

chrome/browser/ui/intents/web_intent_picker_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/intents/web_intent_picker_controller.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 587 matching lines @@
     }
   }
 
   AsyncOperationFinished();
 }
 
 void WebIntentPickerController::OnCWSIntentServicesAvailable(
     const CWSIntentsRegistry::IntentExtensionList& extensions) {
   ExtensionServiceInterface* extension_service =
       tab_contents_->profile()->GetExtensionService();
+
+  std::vector<WebIntentPickerModel::SuggestedExtension> suggestions;
   for (size_t i = 0; i < extensions.size(); ++i) {
     const CWSIntentsRegistry::IntentExtensionInfo& info = extensions[i];
+
+    // Do not include suggestions for already installed extensions.
     if (extension_service->GetExtensionById(UTF16ToUTF8(info.id),
-                                            true)) {  // Include disabled.
+                                            true)) {
       continue;
     }
 
-    picker_model_->AddSuggestedExtension(
-        info.name,
-        info.id,
-        info.average_rating);
+    suggestions.push_back(WebIntentPickerModel::SuggestedExtension(
+        info.name, info.id, info.average_rating));
 
     pending_async_count_++;
     net::URLFetcher* icon_url_fetcher = net::URLFetcher::Create(
         0,
         info.icon_url,
         net::URLFetcher::GET,
         new URLFetcherTrampoline(
             base::Bind(
                 &WebIntentPickerController::OnExtensionIconURLFetchComplete,
                 weak_ptr_factory_.GetWeakPtr(), info.id)));
 
     icon_url_fetcher->SetLoadFlags(
         net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES);
     icon_url_fetcher->SetRequestContext(
         tab_contents_->profile()->GetRequestContext());
     icon_url_fetcher->Start();
   }
 
+  picker_model_->AddSuggestedExtensions(suggestions);
+
   AsyncOperationFinished();
 }
 
 void WebIntentPickerController::OnExtensionIconURLFetchComplete(
     const string16& extension_id, const net::URLFetcher* source) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   if (source->GetResponseCode() != 200) {
     AsyncOperationFinished();
     return;
   }
@@ skipping 119 matching lines @@
   // If picker is non-NULL, it was set by a test.
   if (picker_ == NULL)
     picker_ = WebIntentPicker::Create(tab_contents_, this, picker_model_.get());
   picker_shown_ = true;
 }
 
 void WebIntentPickerController::ClosePicker() {
   if (picker_)
     picker_->Close();
 }