Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 10825343: Fixing focussing issue when bubble opens (Closed)

Created:
8 years, 4 months ago by Mr4D (OOO till 08-26)
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Fixing focussing issue when bubble opens BUG=141493 TEST=unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M ash/wm/custom_frame_view_ash_unittest.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M ash/wm/maximize_bubble_controller.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mr4D (OOO till 08-26)
Fixed activation issue. Please have a look!
8 years, 4 months ago (2012-08-14 16:17:58 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-14 16:53:13 UTC) #2
sky
After this patch do mouse clicks on the buttons still work?
8 years, 4 months ago (2012-08-14 16:53:46 UTC) #3
Mr4D (OOO till 08-26)
Yes. Granted. I was surprised. But this was the only way to get it to ...
8 years, 4 months ago (2012-08-14 18:11:06 UTC) #4
sky
I just wanted to make sure this didn't cause problems. And yes on the unit ...
8 years, 4 months ago (2012-08-14 20:07:26 UTC) #5
Mr4D (OOO till 08-26)
I just realized - the unit test for this is already in place. (named "MaximizeLeftByButton"). ...
8 years, 4 months ago (2012-08-15 14:34:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/10825343/1
8 years, 4 months ago (2012-08-15 14:34:50 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 16:53:50 UTC) #8
Change committed as 151707

Powered by Google App Engine
This is Rietveld 408576698