Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5457)

Unified Diff: chrome/tools/build/win/create_installer_archive.py

Issue 10825342: Do not compress chrome.7z into chrome.packed.7z for developer (component) builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more fixes Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/tools/build/win/create_installer_archive.py
diff --git a/chrome/tools/build/win/create_installer_archive.py b/chrome/tools/build/win/create_installer_archive.py
index b01468a7212f467a4d6b2c22f3e428a0f85f10c8..4a1f149557039217fee53a4fbb0e2c9263492074 100755
--- a/chrome/tools/build/win/create_installer_archive.py
+++ b/chrome/tools/build/win/create_installer_archive.py
@@ -210,6 +210,14 @@ def CreateArchiveFile(options, staging_dir, current_version, prev_version):
os.remove(archive_file)
RunSystemCommand(cmd)
+ # Do not compress the archive in developer (component) builds.
+ if options.component_build == '1':
+ compressed_file = os.path.join(
+ options.output_dir, options.output_name + COMPRESSED_ARCHIVE_SUFFIX)
+ if os.path.exists(compressed_file):
+ os.remove(compressed_file)
+ return os.path.basename(archive_file)
+
# If we are generating a patch, run bsdiff against previous build and
# compress the resulting patch file. If this is not a patch just compress the
# uncompressed archive file.
@@ -564,7 +572,9 @@ def _ParseOptions():
help='Whether to include resource files from the "TOUCH" section of the '
'input file.')
parser.add_option('--component_build', default='0',
- help='Whether this archive is packaging a component build.')
+ help='Whether this archive is packaging a component build. This will '
+ 'also turn off compression of chrome.7z into chrome.packed.7z and '
+ 'helpfully delete any old chrome.packed.7z in |output_dir|.')
options, _ = parser.parse_args()
if not options.build_dir:

Powered by Google App Engine
This is Rietveld 408576698