Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: chrome/tools/build/win/create_installer_archive.py

Issue 10825342: Do not compress chrome.7z into chrome.packed.7z for developer (component) builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/tools/build/win/create_installer_archive.py
diff --git a/chrome/tools/build/win/create_installer_archive.py b/chrome/tools/build/win/create_installer_archive.py
index b01468a7212f467a4d6b2c22f3e428a0f85f10c8..b6c162328f54baf39433cd834c4a8bc735d817a0 100755
--- a/chrome/tools/build/win/create_installer_archive.py
+++ b/chrome/tools/build/win/create_installer_archive.py
@@ -210,6 +210,13 @@ def CreateArchiveFile(options, staging_dir, current_version, prev_version):
os.remove(archive_file)
RunSystemCommand(cmd)
+ if options.skip_compress_archive == '1':
+ compressed_file = os.path.join(
+ options.output_dir, options.output_name + COMPRESSED_ARCHIVE_SUFFIX)
+ if os.path.exists(compressed_file):
+ os.remove(compressed_file)
+ return options.output_name + ARCHIVE_SUFFIX
robertshield 2012/08/14 16:45:28 change this to os.path.basename(archive_file)
gab 2012/08/14 19:15:37 Done.
+
# If we are generating a patch, run bsdiff against previous build and
# compress the resulting patch file. If this is not a patch just compress the
# uncompressed archive file.
@@ -565,6 +572,9 @@ def _ParseOptions():
'input file.')
parser.add_option('--component_build', default='0',
help='Whether this archive is packaging a component build.')
+ parser.add_option('--skip_compress_archive', default='0',
+ help='Whether compressing chrome.7z into chrome.packed.7z should be '
+ 'skipped.')
robertshield 2012/08/14 16:45:28 Mention that this also deletes any existing chrome
gab 2012/08/14 19:15:37 Wrote an inspiring comment :)
options, _ = parser.parse_args()
if not options.build_dir:

Powered by Google App Engine
This is Rietveld 408576698