Do not compress chrome.7z into chrome.packed.7z for developer (component) builds.

chrome/installer/setup/install_worker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains the definitions of the installer functions that build
 // the WorkItemList used to install the application.
 
 #include "chrome/installer/setup/install_worker.h"
 
 #include <oaidl.h>
@@ skipping 98 matching lines @@
                                       temp_path.value(), WorkItem::ALWAYS);
   }
 
   if (archive_path != archive_dst) {
     // In the past, we copied rather than moved for system level installs so
     // that the permissions of %ProgramFiles% would be picked up.  Now that
     // |temp_path| is in %ProgramFiles% for system level installs (and in
     // %LOCALAPPDATA% otherwise), there is no need to do this for the archive.
     // Setup.exe, on the other hand, is created elsewhere so it must always be
     // copied.
+    // The archive is usually extracted in |temp_path| in which case we want to
+    // move it as mentionned above; however if it is not in |temp_path| (e.g. in

[robertshield, 2012/08/17 16:46:56]

nit: mentioned

[gab, 2012/08/17 17:01:36]

Oops didn't realize I'd left this comment there... unified it with the one
below.

+    // developer (component) builds where we use the archive directly from
+    // the build output), copy it instead of moving it).
+#if !defined(COMPONENT_BUILD)
     install_list->AddMoveTreeWorkItem(archive_path.value(), archive_dst.value(),
                                       temp_path.value(), WorkItem::ALWAYS_MOVE);
+#else  // COMPONENT_BUILD
+    // In the component build setup.exe uses chrome.7z directly, moving it means
+    // that setup.exe cannot be ran again without regenerating the archive, so

[robertshield, 2012/08/17 16:46:56]

ran -> run

[gab, 2012/08/17 17:01:36]

Done.

+    // copy it instead to save developer time.
+    install_list->AddCopyTreeWorkItem(archive_path.value(), archive_dst.value(),
+                                      temp_path.value(), WorkItem::ALWAYS);
+#endif  // COMPONENT_BUILD
   }
 }
 
 // This method adds work items to create (or update) Chrome uninstall entry in
 // either the Control Panel->Add/Remove Programs list or in the Omaha client
 // state key if running under an MSI installer.
 void AddUninstallShortcutWorkItems(const InstallerState& installer_state,
                                    const FilePath& setup_path,
                                    const Version& new_version,
                                    WorkItemList* install_list,
@@ skipping 1446 matching lines @@
                                  machine_state,
                                  setup_path,
                                  new_version,
                                  work_item_list,
                                  false,  // have_child_product
                                  cmd_line,
                                  kCmdQuickEnableApplicationHost);
 }
 
 }  // namespace installer