Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: chrome/browser/extensions/extensions_startup.cc

Issue 10825333: extensions: Print to stdout on all platform with --pack-extension. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: just title Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extensions_startup.cc
diff --git a/chrome/browser/extensions/extensions_startup.cc b/chrome/browser/extensions/extensions_startup.cc
index cd11840f73b394350878e2a49af308d0bb04ba44..64a40254bd6dc394ca27cb16f53897eda598c776 100644
--- a/chrome/browser/extensions/extensions_startup.cc
+++ b/chrome/browser/extensions/extensions_startup.cc
@@ -9,26 +9,31 @@
#include "base/utf_string_conversions.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/simple_message_box.h"
#include "chrome/common/chrome_switches.h"
+namespace {
+
+void PrintPackExtensionMessage(const std::string& message) {
+ base::StringPrintf("%s\n", message.c_str());
+}
+
+} // namespace
+
ExtensionsStartupUtil::ExtensionsStartupUtil() : pack_job_succeeded_(false) {}
void ExtensionsStartupUtil::OnPackSuccess(
const FilePath& crx_path,
const FilePath& output_private_key_path) {
pack_job_succeeded_ = true;
- chrome::ShowMessageBox(NULL, ASCIIToUTF16("Extension Packaging Success"),
- PackExtensionJob::StandardSuccessMessage(crx_path,
- output_private_key_path),
- chrome::MESSAGE_BOX_TYPE_INFORMATION);
+ PrintPackExtensionMessage(
+ UTF16ToUTF8(PackExtensionJob::StandardSuccessMessage(crx_path,
Aaron Boodman 2012/08/15 03:41:43 Indent is weird here. I think that PackExtensionJo
+ output_private_key_path)));
}
void ExtensionsStartupUtil::OnPackFailure(
const std::string& error_message,
extensions::ExtensionCreator::ErrorType type) {
- chrome::ShowMessageBox(NULL, ASCIIToUTF16("Extension Packaging Error"),
- UTF8ToUTF16(error_message), chrome::MESSAGE_BOX_TYPE_WARNING);
+ PrintPackExtensionMessage(error_message);
}
bool ExtensionsStartupUtil::PackExtension(const CommandLine& cmd_line) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698