Start of New Autofill UI for Windows

chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

Index: chrome/browser/ui/views/autofill/autofill_popup_view_views.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc b/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5abd3be0d0851396ed7d0fcd42e8d7ab15c69156
--- /dev/null
+++ b/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc
@@ -0,0 +1,90 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "autofill_popup_view_views.h"
+
+#include "chrome/browser/autofill/autofill_external_delegate.h"
+#include "chrome/browser/ui/views/frame/browser_view.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_view.h"
+#include "ui/gfx/canvas.h"
+#include "ui/gfx/rect.h"
+
+namespace {
+const SkColor kPopupBackground = SkColorSetARGB(0xFF, 0x00, 0x00, 0x00);
+}  // namespace
+
+class AutofillPopupViewViews::AutofillPopupWidget
+    : public views::Widget,
+      public base::SupportsWeakPtr<AutofillPopupWidget> {
+ public:
+  AutofillPopupWidget() {}
+  virtual ~AutofillPopupWidget() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(AutofillPopupWidget);
+};
+
+AutofillPopupViewViews::AutofillPopupViewViews(
+    content::WebContents* web_contents,
+    AutofillExternalDelegate* external_delegate)
+    : AutofillPopupView(web_contents, external_delegate),
+      web_contents_(web_contents) {
+  SetVisible(false);

[sky, 2012/08/15 21:07:29]

Why do you explicitly hide here?

[csharp, 2012/08/16 19:16:27]

Removed.

+}
+
+AutofillPopupViewViews::~AutofillPopupViewViews() {
+}
+
+void AutofillPopupViewViews::OnPaint(gfx::Canvas* canvas) {
+  // TODO(csharp): Properly draw the popup.
+  canvas->DrawColor(kPopupBackground);
+}
+
+void AutofillPopupViewViews::ShowInternal() {
+  if (!popup_) {
+    BrowserView* browser_view = BrowserView::GetBrowserViewForNativeWindow(

[sky, 2012/08/15 21:07:29]

Why does this need to be browserview?

[csharp, 2012/08/16 19:16:27]

I'm not sure that it should be. The browser view just seemed to be the correct
place to get the parent widget for the autofill popup. Is there a better parent
window or widget to use?

[sky, 2012/08/16 20:00:15]

params.parent = web_contents_->GetView()->GetTopLevelNativeWindow()

Should work equally well and not have a dependency on BrowserView.

[csharp, 2012/08/16 21:39:15]

Done.

+      web_contents_->GetView()->GetTopLevelNativeWindow());

[sky, 2012/08/15 21:07:29]

spacing is off.

[csharp, 2012/08/16 19:16:27]

Done.

+
+    // The widget is destroyed by the corresponding NativeWidget, so we use
+    // a weak pointer to hold the reference and don't have to worry about
+    // deletion.
+    popup_ = (new AutofillPopupWidget)->AsWeakPtr();
+    views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP);
+    params.can_activate = false;
+    params.transparent = true;
+    params.parent_widget = browser_view->GetWidget();
+    popup_->Init(params);
+    popup_->SetContentsView(this);
+    popup_->Show();
+
+    gfx::Rect client_area;
+    web_contents_->GetContainerBounds(&client_area);
+    popup_->SetBounds(client_area);

[sky, 2012/08/15 21:07:29]

Where do you close this?

[csharp, 2012/08/16 19:16:27]

I'm not sure what you mean. ResizePopup set the bounds of the autofill popup to
the actual size we want (if that's what you mean).

+  }
+
+  ResizePopup();
+
+  web_contents_->GetRenderViewHost()->AddKeyboardListener(this);
+
+  SetVisible(true);

[sky, 2012/08/15 21:07:29]

I don't understand why you need the explicit visible calls here.

[csharp, 2012/08/16 19:16:27]

Ah, I thought I needed it, removed.

+}
+
+void AutofillPopupViewViews::HideInternal() {
+  web_contents_->GetRenderViewHost()->RemoveKeyboardListener(this);
+
+  SetVisible(false);
+}
+
+void AutofillPopupViewViews::InvalidateRow(size_t row) {
+  // TODO(csharp): invalidate this row.
+}
+
+void AutofillPopupViewViews::ResizePopup() {
+  gfx::Rect popup_bounds = element_bounds();
+  popup_bounds.set_y(popup_bounds.y() + popup_bounds.height());
+
+  SetBoundsRect(popup_bounds);
+}