Start of New Autofill UI for Windows

chrome/browser/ui/views/autofill/autofill_popup_view_views.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_POPUP_VIEW_VIEWS_H_
+#define CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_POPUP_VIEW_VIEWS_H_
+
+#include "chrome/browser/autofill/autofill_popup_view.h"
+#include "content/public/browser/keyboard_listener.h"
+#include "ui/views/widget/widget_delegate.h"
+
+class AutofillExternalDelegateViews;
+
+namespace content {
+class RenderViewHost;

[tfarina, 2012/09/02 12:13:25]

unused here.

[csharp, 2012/09/05 17:28:52]

Done.

+class WebContents;
+}
+
+namespace gfx {
+class Rect;

[tfarina, 2012/09/02 12:13:25]

unused here.

[csharp, 2012/09/05 17:28:52]

Done.

+}
+
+// The View Autofill popup implementation.
+class AutofillPopupViewViews : public views::WidgetDelegateView,
+                               public AutofillPopupView,
+                               public KeyboardListener {

[tfarina, 2012/09/02 12:13:25]

ouch, looks like this isn't in content namespace. I'll make a patch for this and
send to John.

[tfarina, 2012/09/02 12:13:25]

Looks like you don't need to inherit from KeyboardListener, unless you are
planning to add views support to it, because at the time I'm writing this, it
seems to be gtk specific.

"virtual bool HandleKeyPressEvent(GdkEventKey* event) = 0;"

[csharp, 2012/09/05 17:28:52]

Yup, I do plan on adding views support later.

+ public:
+  AutofillPopupViewViews(content::WebContents* web_contents,
+                         AutofillExternalDelegateViews* external_delegate);
+
+ private:
+  class AutofillPopupWidget;
+
+  virtual ~AutofillPopupViewViews();
+
+  // views:Views implementation.
+  virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
+

[tfarina, 2012/09/02 12:13:25]

remove extra blank line here.

[csharp, 2012/09/05 17:28:52]

Done.

+
+  // AutofillPopupView implementation.
+  virtual void ShowInternal() OVERRIDE;
+  virtual void HideInternal() OVERRIDE;
+  virtual void InvalidateRow(size_t row) OVERRIDE;
+  virtual void ResizePopup() OVERRIDE;
+
+  AutofillExternalDelegateViews* external_delegate_;  // Weak reference.
+  content::WebContents* web_contents_;  // Weak reference.

[tfarina, 2012/09/02 12:13:25]

nit: I prefer // Not owned.

But that is just my personal preference ;)

+
+  DISALLOW_COPY_AND_ASSIGN(AutofillPopupViewViews);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_AUTOFILL_AUTOFILL_POPUP_VIEW_VIEWS_H_