Start of New Autofill UI for Windows

chrome/browser/ui/views/autofill/autofill_external_delegate_views.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/autofill/autofill_external_delegate_views.h"
+
+#include "chrome/browser/ui/views/autofill/autofill_popup_view_views.h"
+
+AutofillExternalDelegate* AutofillExternalDelegate::Create(
+    TabContents* tab_contents,
+    AutofillManager* autofill_manager) {
+  return new AutofillExternalDelegateViews(tab_contents, autofill_manager);
+}
+
+AutofillExternalDelegateViews::AutofillExternalDelegateViews(
+    TabContents* tab_contents,
+    AutofillManager* autofill_manager)
+    : AutofillExternalDelegate(tab_contents, autofill_manager),
+      view_(NULL) {
+}
+
+AutofillExternalDelegateViews::~AutofillExternalDelegateViews() {
+  delete view_;
+}
+
+void AutofillExternalDelegateViews::InvalidateView() {
+  view_ = NULL;
+}
+
+void AutofillExternalDelegateViews::HideAutofillPopupInternal() {
+  if (!view_)
+    return;
+
+  view_->Hide();

[sky, 2012/08/16 23:02:01]

I know I asked this before, but how come delete view_ isn't enough? Can't it be?

[csharp, 2012/08/20 20:59:00]

Hide calls a virtual function in view_, so I can't merge the call inside the
deletion, but I still need to ensure it is called to ensure that the base class
hiding code gets executed.

[sky, 2012/08/21 15:29:41]

Can't the destructor in the base class take care of whatever cleanup needs to be
done?

[csharp, 2012/08/21 20:23:57]

Done.

+
+  delete view_;
+  view_ = NULL;
+}
+
+void AutofillExternalDelegateViews::OnQueryPlatformSpecific(
+    int query_id,
+    const webkit::forms::FormData& form,
+    const webkit::forms::FormField& field,
+    const gfx::Rect& bounds) {
+  CreateViewIfNeeded();
+  view_->set_element_bounds(bounds);
+}
+
+void AutofillExternalDelegateViews::ApplyAutofillSuggestions(
+    const std::vector<string16>& autofill_values,
+    const std::vector<string16>& autofill_labels,
+    const std::vector<string16>& autofill_icons,
+    const std::vector<int>& autofill_unique_ids) {
+  CreateViewIfNeeded();
+
+  view_->Show(autofill_values,
+              autofill_labels,
+              autofill_icons,
+              autofill_unique_ids);
+}
+
+void AutofillExternalDelegateViews::SetBounds(const gfx::Rect& bounds) {
+  view_->SetBoundsRect(bounds);
+}
+
+void AutofillExternalDelegateViews::CreateViewIfNeeded() {
+  if (!view_)
+    view_ = new AutofillPopupViewViews(web_contents(), this);
+}