Start of New Autofill UI for Windows

chrome/browser/ui/views/autofill/autofill_popup_view_views.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "autofill_popup_view_views.h"
+
+#include "chrome/browser/ui/views/autofill/autofill_external_delegate_views.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_view.h"
+#include "ui/gfx/canvas.h"
+#include "ui/gfx/rect.h"
+#include "ui/views/widget/widget.h"
+
+namespace {
+const SkColor kPopupBackground = SkColorSetARGB(0xFF, 0x00, 0x00, 0x00);
+}  // namespace
+
+class AutofillPopupViewViews::AutofillPopupWidget
+    : public views::Widget,
+      public base::SupportsWeakPtr<AutofillPopupWidget> {
+ public:
+  AutofillPopupWidget() {}
+  virtual ~AutofillPopupWidget() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(AutofillPopupWidget);
+};
+
+AutofillPopupViewViews::AutofillPopupViewViews(
+    content::WebContents* web_contents,
+    AutofillExternalDelegateViews* external_delegate)
+    : AutofillPopupView(web_contents, external_delegate),
+      external_delegate_(external_delegate),
+      web_contents_(web_contents) {
+}
+
+AutofillPopupViewViews::~AutofillPopupViewViews() {
+  if (popup_.get())

[sky, 2012/08/21 22:27:38]

Did you verify this all works correctly if the widget is destroyed out from
under you? In particular because the widget effectively owns this it'll try
deleting this and popup_ will still be valid and you'll unnecessarily call out
to Close().

The typical pattern for code like this is to subclass WidgetDelegateView and key
off WindowClosing or DeleteDelegate.

[csharp, 2012/08/23 19:44:18]

Done.

+    popup_->Close();
+  external_delegate_->InvalidateView();
+}
+
+void AutofillPopupViewViews::OnPaint(gfx::Canvas* canvas) {
+  // TODO(csharp): Properly draw the popup.
+  canvas->DrawColor(kPopupBackground);
+}
+
+void AutofillPopupViewViews::ShowInternal() {
+  if (!popup_.get()) {
+    // The widget is destroyed by the corresponding NativeWidget, so we use
+    // a weak pointer to hold the reference and don't have to worry about
+    // deletion.
+    popup_ = (new AutofillPopupWidget)->AsWeakPtr();
+    views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP);
+    params.can_activate = false;
+    params.transparent = true;
+    params.parent = web_contents_->GetView()->GetTopLevelNativeWindow();
+    popup_->Init(params);
+    popup_->SetContentsView(this);
+    popup_->Show();
+
+    gfx::Rect client_area;
+    web_contents_->GetContainerBounds(&client_area);
+    popup_->SetBounds(client_area);
+  }
+
+  ResizePopup();
+
+  web_contents_->GetRenderViewHost()->AddKeyboardListener(this);
+}
+
+void AutofillPopupViewViews::HideInternal() {
+  web_contents_->GetRenderViewHost()->RemoveKeyboardListener(this);
+
+  if (popup_.get())
+    popup_->Hide();
+  SetVisible(false);

[sky, 2012/08/21 22:27:38]

Why the SetVisible(false) here? Additionally are you sure HideInternal shouldn't
be Close (aka delayed delete)?

[csharp, 2012/08/23 19:44:18]

Good point, changed.

+}
+
+void AutofillPopupViewViews::InvalidateRow(size_t row) {
+  // TODO(csharp): invalidate this row.
+}
+
+void AutofillPopupViewViews::ResizePopup() {
+  gfx::Rect popup_bounds = element_bounds();
+  popup_bounds.set_y(popup_bounds.y() + popup_bounds.height());
+
+  SetBoundsRect(popup_bounds);
+}