Re-Enable the About menu option on non-cros-touch.

Re-Enable the About menu option on non-cros-touch.

BUG=140281
TEST=Make sure the About Google Chrome options shows up in the wrench menu went we want it, and doesn't when we don't :-)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151041

[MAD, 2012-08-09 18:37:43]

Would this be OK for you?

Thanks!

BYE
MAD...

[Mr4D (OOO till 08-26), 2012-08-09 19:19:36]

lgtm

[commit-bot: I haz the power, 2012-08-09 19:33:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mad@chromium.org/10825281/1

[commit-bot: I haz the power, 2012-08-09 19:33:35]

Presubmit check for 10825281-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui

[MAD, 2012-08-09 19:34:47]

On 2012/08/09 19:19:36, Mr4D wrote:
> lgtm

Thanks!

[MAD, 2012-08-09 19:37:10]

Need a chrome\browser\ui\OWNERS' LGTM...

Tempted to TBR very simple change, but prefer to let you take a quick look...
Just in case...

Thanks!

BYE
MAD...

[Ben Goodger (Google), 2012-08-09 21:24:10]

lgtm

https://chromiumcodereview.appspot.com/10825281/diff/1/chrome/browser/ui/tool...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

https://chromiumcodereview.appspot.com/10825281/diff/1/chrome/browser/ui/tool...
chrome/browser/ui/toolbar/wrench_menu_model.cc:508: // On ChormeOS-Touch, we
don't want the about/background pages menu options.
ChromeOS

[MAD, 2012-08-09 21:45:31]

Thanks... CQing...

Sorry about the sync'd changes mixed in with the patch.

BYE
MAD

http://codereview.chromium.org/10825281/diff/1/chrome/browser/ui/toolbar/wren...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

http://codereview.chromium.org/10825281/diff/1/chrome/browser/ui/toolbar/wren...
chrome/browser/ui/toolbar/wrench_menu_model.cc:508: // On ChormeOS-Touch, we
don't want the about/background pages menu options.
On 2012/08/09 21:24:10, Ben Goodger (Google) wrote:
> ChromeOS

D'Ho!ne. :-)

[commit-bot: I haz the power, 2012-08-09 21:46:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mad@chromium.org/10825281/9001

[commit-bot: I haz the power, 2012-08-09 23:22:21]

Try job failure for 10825281-9001 (retry) on win_rel for step "runhooks".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-10 14:16:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mad@chromium.org/10825281/9001

[commit-bot: I haz the power, 2012-08-10 15:41:10]

Change committed as 151041