Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10825240: Refactor ShellWindow to separate platform-specific code. (Closed)

Created:
8 years, 4 months ago by jeremya
Modified:
8 years, 4 months ago
CC:
chromium-reviews, jeremya+watch_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Refactor ShellWindow to separate platform-specific code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152063

Patch Set 1 #

Patch Set 2 : missing file #

Total comments: 6

Patch Set 3 : remove virtuals #

Patch Set 4 : mac #

Patch Set 5 : gtk #

Total comments: 8

Patch Set 6 : comments #

Total comments: 1

Patch Set 7 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -113 lines) Patch
M chrome/browser/extensions/api/app_window/app_window_api.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest_util.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/shell_window_registry.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/shell_window_cocoa.h View 1 2 3 4 5 3 chunks +18 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm View 1 2 3 5 chunks +11 lines, -11 lines 0 comments Download
A chrome/browser/ui/extensions/native_shell_window.h View 1 2 3 4 5 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.h View 1 2 3 4 5 6 5 chunks +20 lines, -22 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 2 3 4 5 6 8 chunks +29 lines, -21 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/shell_window_gtk.h View 1 2 3 4 5 6 4 chunks +15 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/shell_window_gtk.cc View 1 2 3 4 5 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/extensions/shell_window_views.h View 1 2 3 4 5 5 chunks +20 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/extensions/shell_window_views.cc View 1 2 3 6 chunks +12 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
jeremya
Hi Ben, This is the PIMPL refactor you suggested a while ago -- could you ...
8 years, 4 months ago (2012-08-08 07:04:59 UTC) #1
Ben Goodger (Google)
https://chromiumcodereview.appspot.com/10825240/diff/2001/chrome/browser/ui/extensions/shell_window.h File chrome/browser/ui/extensions/shell_window.h (right): https://chromiumcodereview.appspot.com/10825240/diff/2001/chrome/browser/ui/extensions/shell_window.h#newcode68 chrome/browser/ui/extensions/shell_window.h:68: virtual BaseWindow* GetBaseWindow(); does this need to be virtual?
8 years, 4 months ago (2012-08-08 16:58:28 UTC) #2
tfarina
http://codereview.chromium.org/10825240/diff/2001/chrome/browser/ui/views/extensions/shell_window_views.h File chrome/browser/ui/views/extensions/shell_window_views.h (right): http://codereview.chromium.org/10825240/diff/2001/chrome/browser/ui/views/extensions/shell_window_views.h#newcode86 chrome/browser/ui/views/extensions/shell_window_views.h:86: virtual content::WebContents* web_contents() { Does these needs to be ...
8 years, 4 months ago (2012-08-09 16:20:19 UTC) #3
tfarina
http://codereview.chromium.org/10825240/diff/2001/chrome/browser/ui/extensions/native_shell_window.h File chrome/browser/ui/extensions/native_shell_window.h (right): http://codereview.chromium.org/10825240/diff/2001/chrome/browser/ui/extensions/native_shell_window.h#newcode12 chrome/browser/ui/extensions/native_shell_window.h:12: public: missing virtual destructor?
8 years, 4 months ago (2012-08-09 16:27:45 UTC) #4
jeremya
http://codereview.chromium.org/10825240/diff/2001/chrome/browser/ui/extensions/native_shell_window.h File chrome/browser/ui/extensions/native_shell_window.h (right): http://codereview.chromium.org/10825240/diff/2001/chrome/browser/ui/extensions/native_shell_window.h#newcode12 chrome/browser/ui/extensions/native_shell_window.h:12: public: On 2012/08/09 16:27:45, tfarina wrote: > missing virtual ...
8 years, 4 months ago (2012-08-09 23:59:53 UTC) #5
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-10 15:00:44 UTC) #6
jeremya
+rsesek for mac part
8 years, 4 months ago (2012-08-13 04:45:03 UTC) #7
Robert Sesek
cocoa/ LGTM
8 years, 4 months ago (2012-08-13 21:17:26 UTC) #8
jeremya
+estade for gtk/
8 years, 4 months ago (2012-08-14 00:22:57 UTC) #9
Evan Stade
http://codereview.chromium.org/10825240/diff/1008/chrome/browser/ui/extensions/native_shell_window.h File chrome/browser/ui/extensions/native_shell_window.h (right): http://codereview.chromium.org/10825240/diff/1008/chrome/browser/ui/extensions/native_shell_window.h#newcode11 chrome/browser/ui/extensions/native_shell_window.h:11: class NativeShellWindow : public BaseWindow { can you document ...
8 years, 4 months ago (2012-08-14 21:33:02 UTC) #10
jeremya
https://chromiumcodereview.appspot.com/10825240/diff/1008/chrome/browser/ui/extensions/native_shell_window.h File chrome/browser/ui/extensions/native_shell_window.h (right): https://chromiumcodereview.appspot.com/10825240/diff/1008/chrome/browser/ui/extensions/native_shell_window.h#newcode11 chrome/browser/ui/extensions/native_shell_window.h:11: class NativeShellWindow : public BaseWindow { On 2012/08/14 21:33:02, ...
8 years, 4 months ago (2012-08-15 00:31:54 UTC) #11
Evan Stade
lgtm
8 years, 4 months ago (2012-08-15 00:39:37 UTC) #12
Evan Stade
https://chromiumcodereview.appspot.com/10825240/diff/2003/chrome/browser/ui/gtk/extensions/shell_window_gtk.h File chrome/browser/ui/gtk/extensions/shell_window_gtk.h (right): https://chromiumcodereview.appspot.com/10825240/diff/2003/chrome/browser/ui/gtk/extensions/shell_window_gtk.h#newcode75 chrome/browser/ui/gtk/extensions/shell_window_gtk.h:75: ShellWindow* shell_window_; // weak - ShellWindow owns NativeShellWindow. 2 ...
8 years, 4 months ago (2012-08-15 00:39:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/10825240/14013
8 years, 4 months ago (2012-08-17 02:58:54 UTC) #14
commit-bot: I haz the power
Try job failure for 10825240-14013 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-17 04:37:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/10825240/14013
8 years, 4 months ago (2012-08-17 05:41:40 UTC) #16
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 07:56:42 UTC) #17 
Change committed as 152063

Powered by Google App Engine
This is Rietveld 408576698