Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8548)

Unified Diff: chrome/browser/chromeos/gdata/gdata_files.h

Issue 10825218: Simplify implementation of FindEntryByPathSync (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_files.h
===================================================================
--- chrome/browser/chromeos/gdata/gdata_files.h (revision 150246)
+++ chrome/browser/chromeos/gdata/gdata_files.h (working copy)
@@ -286,6 +286,10 @@
void RemoveChildFiles();
void RemoveChildDirectories();
+ // Find child by its name.
+ void FindChildAsync(const FilePath::StringType& file_name,
satorux1 2012/08/07 10:43:46 base_name ?
+ const FindEntryCallback& callback) const;
+
// Collection of children files/directories.
const GDataFileCollection& child_files() const { return child_files_; }
const GDataDirectoryCollection& child_directories() const {
@@ -307,7 +311,7 @@
// Removes the entry from its children list and destroys the entry instance.
// TODO(satorux): Remove this. crbug.com/139649
- bool RemoveEntry(GDataEntry* entry);
+ void RemoveEntry(GDataEntry* entry);
// Takes the ownership of |entry| from its current parent. If this directory
// is already the current parent of |file|, this method effectively goes
@@ -329,7 +333,7 @@
// Removes the entry from its children without destroying the
// entry instance.
- bool RemoveChild(GDataEntry* entry);
+ void RemoveChild(GDataEntry* entry);
// Collection of children GDataEntry items.
GDataFileCollection child_files_;
@@ -345,7 +349,6 @@
public:
// Callback for GetEntryByResourceIdAsync.
typedef base::Callback<void(GDataEntry* entry)> GetEntryByResourceIdCallback;
-
// Map of resource id and serialized GDataEntry.
typedef std::map<std::string, std::string> SerializedMap;

Powered by Google App Engine
This is Rietveld 408576698