Support also excluding content types in declarative webrequest conditions.

Support also excluding content types in declarative webrequest conditions.

BUG=112155
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150421

[battre, 2012-08-07 08:45:09]

lgtm

http://codereview.chromium.org/10825212/diff/3001/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc
(right):

http://codereview.chromium.org/10825212/diff/3001/chrome/browser/extensions/a...
chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc:149:
: content_types_(content_types), inclusive_(inclusive) {}
nit: I think the inclusive_ should go into the next line
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr...)

[Yoyo Zhou, 2012-08-07 19:32:35]

http://codereview.chromium.org/10825212/diff/3001/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc
(right):

http://codereview.chromium.org/10825212/diff/3001/chrome/browser/extensions/a...
chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc:149:
: content_types_(content_types), inclusive_(inclusive) {}
On 2012/08/07 08:45:09, battre wrote:
> nit: I think the inclusive_ should go into the next line
>
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr...)

I think the style guide can be construed either way in this case, but I think
the 2 lines looks better here.

[commit-bot: I haz the power, 2012-08-07 19:33:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/10825212/10002

[commit-bot: I haz the power, 2012-08-07 19:33:52]

Presubmit check for 10825212-10002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
 - Changes to chrome/common/extensions/docs/static/declarativeWebRequest.html
not reflected in generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py --page-name=<apiName>