native_client_sdk/src/libraries/nacl_mounts/kernel_handle.h - Issue 10825189: [NaCl SDK] Get nacl_mounts_tests building.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: native_client_sdk/src/libraries/nacl_mounts/kernel_handle.h

Issue 10825189: [NaCl SDK] Get nacl_mounts_tests building. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: windows fixes Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « native_client_sdk/src/libraries/gtest/nacl_gtest_dummy_sys.cc ('k') | native_client_sdk/src/libraries/nacl_mounts/mount.h » ('j') | native_client_sdk/src/libraries/nacl_mounts_test/mount_test.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 * Use of this source code is governed by a BSD-style license that can be	2 * Use of this source code is governed by a BSD-style license that can be

3 * found in the LICENSE file.	3 * found in the LICENSE file.

4 */	4 */

5 #ifndef LIBRARIES_NACL_MOUNTS_KERNEL_HANDLE_H_	5 #ifndef LIBRARIES_NACL_MOUNTS_KERNEL_HANDLE_H_

6 #define LIBRARIES_NACL_MOUNTS_KERNEL_HANDLE_H_	6 #define LIBRARIES_NACL_MOUNTS_KERNEL_HANDLE_H_

7	7

8 #include <pthread.h>	8 #include <pthread.h>

9	9

10 #include "utils/macros.h"	10 #include "utils/macros.h"

(...skipping 13 matching lines...) Expand all Loading...
24 MountNode* node_;	24 MountNode* node_;

25 int mode_;	25 int mode_;

26 size_t offs_;	26 size_t offs_;

27	27

28 private:	28 private:

29 // May only be called by the KernelProxy when the Kernel's	29 // May only be called by the KernelProxy when the Kernel's

30 // lock is held.	30 // lock is held.

31 friend class KernelObject;	31 friend class KernelObject;

32 friend class KernelProxy;	32 friend class KernelProxy;

33 void Acquire() { RefObject::Acquire(); }	33 void Acquire() { RefObject::Acquire(); }

34 void Release() { RefObject::Release(); }	34 bool Release() { return RefObject::Release(); }
	noelallen1 2012/08/09 18:26:57 I originally had this as bool, then realized I nev I originally had this as bool, then realized I never looked at the return value of Release. Do you actually use this value? binji 2012/08/09 19:39:23 Yes, see my other comment. Show quoted text On 2012/08/09 18:26:57, noelallen1 wrote: > I originally had this as bool, then realized I never looked at the return value > of Release. Do you actually use this value? Yes, see my other comment.
35 DISALLOW_COPY_AND_ASSIGN(KernelHandle);	35 DISALLOW_COPY_AND_ASSIGN(KernelHandle);

36 };	36 };

37	37

38 #endif // LIBRARIES_NACL_MOUNTS_KERNEL_HANDLE_H_	38 #endif // LIBRARIES_NACL_MOUNTS_KERNEL_HANDLE_H_

OLD	NEW