Suppress "errors" that aren't really errors.

remoting/webapp/suspend_monitor.js

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @fileoverview
+ * Class to detect when the device is suspended. If the device is suspended,
+ * for example, a laptop's lid is closed, any subsequent errors detected by
+ * the active ClientSession should not be logged, as they arise from explicit
+ * user action.
+ */
+
+/**
+ * @param {function():void} callback Callback function to invoke when a
+ * suspend+resume operation has been detected.
+ *
+ * @constructor
+ */
+remoting.SuspendMonitor = function (callback) {
+  /** @type {function():void} @private */
+  this.callback_ = callback;
+  /** @type {number} @private */
+  this.timerIntervalMs_ = 60 * 1000;
+  /** @type {number} @private */
+  this.lateToleranceMs_ = 60 * 1000;
+  /** @type {number} @private */
+  this.callbackExpectedTime_ = 0;
+  this.start_();

[simonmorris, 2012/08/03 21:48:49]

It might be better to start the suspend monitor only when a session is active,
and to stop it when the session ends. It doesn't seem right to suppress errors
just because a user closed their laptop before starting a session.

[Jamie, 2012/08/03 23:15:14]

I don't think that will happen. If the callback is delayed, then it will occur
as soon as the lap-top is opened. In other words, the user won't have time to
initiate anything.

+};
+
+/** @private */
+remoting.SuspendMonitor.prototype.start_ = function() {
+  window.setTimeout(this.checkSuspend_.bind(this), this.timerIntervalMs_);
+  this.callbackExpectedTime_ = new Date().getTime() + this.timerIntervalMs_;
+};
+
+/** @private */
+remoting.SuspendMonitor.prototype.checkSuspend_ = function() {
+  var lateByMs = new Date().getTime() - this.callbackExpectedTime_;
+  if (lateByMs > this.lateToleranceMs_) {
+    this.callback_();

[simonmorris, 2012/08/03 21:48:49]

This will typically be called 30 seconds after the device resumes. Isn't it
likely that the plugin will already have detected and logged an error by then?

[Jamie, 2012/08/03 23:15:14]

That is only true for very short suspension periods. As long as the device is
asleep for more than 2m, the callback will be invoked as soon as it resumes.

+  }
+  this.start_();
+};
+
+/** @type {remoting.SuspendMonitor?} */
+remoting.suspendMonitor = null;