Turning off blending for part of the animation to reduce jank.

Turning off blending for part of the animation to reduce jank.
This change only turns on blending for the last part
of the minimize and first part of the maximize animation
to save bandwidth and increase frame rate.

This change also properly hides the window only once the animation
is complete instead of cutting off the minimize animation with an
implicit one.

BUG=135177
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151271

[Ian Vollick, 2012-08-09 15:30:52]

Nice! LGTM

[Ian Vollick, 2012-08-10 12:34:10]

+sky for OWNERS

[sky, 2012-08-10 15:47:39]

http://codereview.chromium.org/10825162/diff/1/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

http://codereview.chromium.org/10825162/diff/1/ash/wm/window_animations.cc#ne...
ash/wm/window_animations.cc:153: window_->layer()->SetVisible(false);
If you do this then the TargetVisibility is true after invoking Hide(), which we
don't want and is likely to cause problems. I think this has to be @ 473.

[alexst (slow to review), 2012-08-10 17:50:55]

http://codereview.chromium.org/10825162/diff/1/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

http://codereview.chromium.org/10825162/diff/1/ash/wm/window_animations.cc#ne...
ash/wm/window_animations.cc:153: window_->layer()->SetVisible(false);
Ah, this was the wrong solution to a real problem.
Animation that hid the window was not sync'd with the minimize animation.
Solution in this patch was setting visibility at the end of the animation. New
patch will alter the implicit animation's time instead.

On 2012/08/10 15:47:39, sky wrote:
> If you do this then the TargetVisibility is true after invoking Hide(), which
we
> don't want and is likely to cause problems. I think this has to be @ 473.

[sky, 2012-08-10 19:12:06]

LGTM

[commit-bot: I haz the power, 2012-08-13 14:02:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexst@chromium.org/10825162/10001

[commit-bot: I haz the power, 2012-08-13 15:25:29]

Change committed as 151271