gdata: Cleanup GDataFileSystem::AddUploadedFileOnUIThread().

gdata: Cleanup GDataFileSystem::AddUploadedFileOnUIThread().

Use ScopedClosureRunner to simplify callback invocation. This ensures
the callback is always either invoked or passed on, and eliminates
the need to DCHECK(!callback.is_null()).

BUG=none
TEST=unit_tests, manual upload tests.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149706

[hshi1, 2012-08-02 19:00:09]

Hi I recently stumbled upon the class base::ScopedClosureRunner, and I'm
wondering if it would be beneficial to utilize this to clean up the awkward
callback invocation in GDataFileSystem::AddUploadedFileOnUIThread()? Thanks.

[achuithb, 2012-08-02 19:07:31]

I like it!

lgtm

[achuithb, 2012-08-02 19:08:37]

http://codereview.chromium.org/10825160/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10825160/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:3530:
base::ScopedClosureRunner callback_runner(callback);
nit: Please add a comment since this is not commonly used in chromium code base.

[satorux1, 2012-08-02 19:41:13]

lgtm. Thank you for sharing the finding!

http://codereview.chromium.org/10825160/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10825160/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:3530:
base::ScopedClosureRunner callback_runner(callback);
ah this is pretty cool.

[hshi1, 2012-08-02 19:55:12]

http://codereview.chromium.org/10825160/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10825160/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:3530:
base::ScopedClosureRunner callback_runner(callback);
On 2012/08/02 19:08:37, achuith.bhandarkar wrote:
> nit: Please add a comment since this is not commonly used in chromium code
base.
> 

Done.

[commit-bot: I haz the power, 2012-08-02 19:55:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hshi@chromium.org/10825160/10002

[commit-bot: I haz the power, 2012-08-02 21:43:26]

Change committed as 149706