Build target for Android WebView.

android_webview/lib/main/webview_stubs.cc

Index: android_webview/lib/main/webview_stubs.cc
diff --git a/android_webview/lib/main/webview_stubs.cc b/android_webview/lib/main/webview_stubs.cc
new file mode 100644
index 0000000000000000000000000000000000000000..abdd15613df7e9f27ac0981ca35479024d7e4aed
--- /dev/null
+++ b/android_webview/lib/main/webview_stubs.cc
@@ -0,0 +1,27 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/android/tab_android.h"
+#include "chrome/browser/autofill/autofill_external_delegate.h"
+
+// This file contains temporary stubs to allow the libwebview target to compile.
+// They will be removed once real implementations are written/upstreamed, or

[Jói, 2012/08/07 13:49:47]

For my enlightenment:  Does this mean the previous implementation is currently
#ifdef'ed out under chrome/ ?

[Torne, 2012/08/07 13:58:09]

There's currently no real implementation of TabAndroid in the upstream tree at
all; just stubs for test purposes. The real implementation only exists in the
downstream fork and that version is unlikely to be suitable for WebView's
purposes; we will probably write our own implementation from scratch, it's just
not yet been necessary.

AutofillExternalDelegate::Create is already ifdef'ed for OS_ANDROID because
there is, again, a separate downstream implementation that hasn't been
upstreamed yet, and currently the upstream tree only has a stub test version for
Android.

[joth, 2012/08/07 17:19:57]

Actually it turns out that http auth dialogs are currently the only thing in
TabAndroid we would actually want for WebView, and even those it's easier to cut
into that functionality at the Content API rather than try and reuse the chrome
layer implementation (that adds a bunch of password autofill complexity we don't
want).

So my aim now is never to make a TabAndroid subclass for webview. The eventual
aim should be not to compile in and code that expects to look up a TabAndroid*,
or if we find some that is needed, refactor it to use a dedicated FooFeature
delegate rather than the catch-all TabAndroid escape hatch.

+// once other code is refactored to eliminate the need for them.
+
+// static
+TabAndroid* TabAndroid::FromWebContents(content::WebContents* web_contents) {
+  // We don't need to return a real TabAndroid object yet.
+  // Eventually, WebView will need its own TabAndroid implementation.
+  return NULL;
+}
+
+// static
+AutofillExternalDelegate* AutofillExternalDelegate::Create(
+    TabContents* tab_contents,
+    AutofillManager* manager) {
+  // We don't need to return a real AutofillExternalDelegate yet.
+  // Eventually, WebView will need an implementation (probably shared with
+  // Chrome).
+  return NULL;
+}