Create a valid RendererPreferences for notification windows.

chrome/browser/notifications/balloon_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/balloon_host.h"
 
 #include "chrome/browser/notifications/balloon.h"
 #include "chrome/browser/notifications/balloon_collection_impl.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 120 matching lines @@
   DCHECK(!web_contents_.get()) << "BalloonViewHost already initialized.";
   web_contents_.reset(WebContents::Create(
       balloon_->profile(),
       site_instance_.get(),
       MSG_ROUTING_NONE,
       NULL,
       NULL));
   chrome::SetViewType(web_contents_.get(), chrome::VIEW_TYPE_NOTIFICATION);
   web_contents_->SetDelegate(this);
   Observe(web_contents_.get());
+  renderer_preferences_util::UpdateFromSystemSettings(
+      web_contents_->GetMutableRendererPrefs(), balloon_->profile());

[stevenjb, 2012/08/02 17:17:34]

Is this modifying web_contents_->GetMutableRendererPrefs()? If so, shouldn't the
arguments be in the reverse order? I realize that might be out of scope for this
CL, but it's not clear from reading this what it is doing.

[kinaba, 2012/08/03 01:39:23]

Yes, this is how the function is defined in 2 or 3 years ago...
I understand your concern, but not sure if it is worth changing.
For this CL, I'll add some comments here to clarify it.

+  web_contents_->GetRenderViewHost()->SyncRendererPrefs();
 
   web_contents_->GetController().LoadURL(
       balloon_->notification().content_url(), content::Referrer(),
       content::PAGE_TRANSITION_LINK, std::string());
 
   initialized_ = true;
 }
 
 void BalloonHost::EnableWebUI() {
   DCHECK(!web_contents_.get()) <<
@@ skipping 22 matching lines @@
 bool BalloonHost::CanLoadDataURLsInWebUI() const {
 #if defined(OS_CHROMEOS)
   // Chrome OS uses data URLs in WebUI BalloonHosts.  We normally do not allow
   // data URLs in WebUI renderers, but normal pages cannot target BalloonHosts,
   // so this should be safe.
   return true;
 #else
   return false;
 #endif
 }