FYI: Control Data + Per-Device Metadata

sync/syncable/nigori_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/syncable/nigori_util.h"
 
 #include <queue>
 #include <string>
 #include <vector>
 
@@ skipping 67 matching lines @@
   return SpecificsNeedsEncryption(encrypted_types, entry.Get(SPECIFICS)) ||
          (encrypted_types.Has(type) &&
           entry.Get(NON_UNIQUE_NAME) != kEncryptedString);
 }
 
 bool SpecificsNeedsEncryption(ModelTypeSet encrypted_types,
                               const sync_pb::EntitySpecifics& specifics) {
   const ModelType type = GetModelTypeFromSpecifics(specifics);
   if (type == PASSWORDS || type == NIGORI)
     return false;  // These types have their own encryption schemes.
+  if (!syncer::EncryptableTypes().Has(type))

[rlarocque, 2012/08/11 01:31:52]

This is a new concept that I'm introducing.  We already have PASSWORDS and
NIGORI which have special encryption treatment.  I'm adding EncryptableTypes()
to make it easier to define types which we expect will never support encryption.

+    return false;  // These types can never be encrypted.
   if (!encrypted_types.Has(type))
-    return false;  // This type does not require encryption
+    return false;  // This type does not require encryption.
   return !specifics.has_encrypted();
 }
 
 // Mainly for testing.
 bool VerifyDataTypeEncryptionForTest(
     BaseTransaction* const trans,
     Cryptographer* cryptographer,
     ModelType type,
     bool is_encrypted) {
   if (type == PASSWORDS || type == NIGORI) {
@@ skipping 141 matching lines @@
   entry->Put(syncable::SPECIFICS, generated_specifics);
   DVLOG(1) << "Overwriting specifics of type "
            << ModelTypeToString(type)
            << " and marking for syncing.";
   syncable::MarkForSyncing(entry);
   return true;
 }
 
 }  // namespace syncable
 }  // namespace syncer