Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5518)

Unified Diff: chrome/browser/resources/options2/chromeos/keyboard_overlay.html

Issue 10825136: Associate keyboard overlay labels with the controls they label. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options2/chromeos/keyboard_overlay.html
===================================================================
--- chrome/browser/resources/options2/chromeos/keyboard_overlay.html (revision 148955)
+++ chrome/browser/resources/options2/chromeos/keyboard_overlay.html (working copy)
@@ -4,7 +4,10 @@
<div class="content-area">
<table class="option-control-table">
<tr>
- <td class="option-name" i18n-content="xkbRemapSearchKeyToContent">
+ <td>
+ <label class="option-name" for="xkb-remap-search-key-to"
+ i18n-content="xkbRemapSearchKeyToContent">
James Hawkins 2012/08/01 20:07:27 nit: Not entirely sure, but it looks like this is
dmazzoni 2012/08/01 20:23:05 It looks like it was a little inconsistent elsewhe
James Hawkins 2012/08/01 20:44:51 Thanks!
+ </label>
</td>
<td class="option-value">
<select id="xkb-remap-search-key-to" class="control"
@@ -14,8 +17,11 @@
</td>
</tr>
<tr>
- <td class="option-name"
- i18n-content="xkbRemapControlKeyToContent"></td>
+ <td>
+ <label class="option-name" for="xkb-remap-control-key-to"
+ i18n-content="xkbRemapControlKeyToContent">
+ </label>
+ </td>
<td class="option-value">
<select id="xkb-remap-control-key-to" class="control"
data-type="number" i18n-options="xkbRemapControlKeyToValue"
@@ -24,7 +30,11 @@
</td>
</tr>
<tr>
- <td class="option-name" i18n-content="xkbRemapAltKeyToContent"></td>
+ <td>
+ <label class="option-name" for="xkb-remap-alt-key-to"
+ i18n-content="xkbRemapAltKeyToContent">
+ </label>
+ </td>
<td class="option-value">
<select id="xkb-remap-alt-key-to" class="control" data-type="number"
pref="settings.language.xkb_remap_alt_key_to"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698