Issue 10825120: gdata: Introduce GDataWapiFeedProcessor class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825120: gdata: Introduce GDataWapiFeedProcessor class (Closed)

Created:
8 years, 4 months ago by satorux1

Modified:
8 years, 4 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Introduce GDataWapiFeedProcessor class This class is introduced to separate code related to WAPI (codename of Documents List API) feed processing. To minimize diffs, the the class is defined in gdata_file_system.cc The code will be moved to a set of new files in a separate patch. BUG=130669 TEST=out/Release/unit_tests --gtest_filter=GData* && out/Release/browser_tests --gtest_filter=GData* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149373

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+150 lines, -102 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View		4 chunks	+4 lines, -54 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	1	16 chunks	+145 lines, -48 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_files.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

achuithb

Yes, this is great! Thanks for helping make the diff readable by not moving all ...

8 years, 4 months ago (2012-08-01 00:00:14 UTC) #2

satorux1

8 years, 4 months ago (2012-08-01 00:56:52 UTC) #3

will submit shortly.

http://codereview.chromium.org/10825120/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10825120/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:607: 
On 2012/08/01 00:00:14, achuith.bhandarkar wrote:
> nit: unnecessary newline

Done.

Expand Messages | Collapse Messages