net-internals: Display time log dump was created at end of printed logs

chrome/test/data/webui/net_internals/log_view_painter.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Include test fixture.
 GEN_INCLUDE(['net_internals_test.js']);
 
 // Anonymous namespace
 (function() {
 
@@ skipping 83 matching lines @@
 TEST_F('NetInternalsTest', 'netInternalsLogViewPainterPrintAsText', function() {
   // Add a DOM node to draw the log entries into.
   var div = addNode(document.body, 'div');
 
   // Helper function to run a particular "test case". This comprises an input
   // and the resulting formatted text expectation.
   function runTestCase(testCase) {
     div.innerHTML = '';
     timeutil.setTimeTickOffset(testCase.tickOffset);
     printLogEntriesAsText(testCase.logEntries, div,
-                          testCase.enableSecurityStripping);
+                          testCase.enableSecurityStripping,
+                          testCase.logCreationTime);
 
     // Strip any trailing newlines, since the whitespace when using innerText
     // can be a bit unpredictable.
     var actualText = div.innerText;
     actualText = actualText.replace(/^\s+|\s+$/g, '');
 
     expectEquals(testCase.expectedText, actualText);
   }
 
   runTestCase(painterTestURLRequest());
+  runTestCase(painterTestURLRequestIncomplete());
+  runTestCase(painterTestURLRequestIncompleteFromLoadedLog());
   runTestCase(painterTestNetError());
   runTestCase(painterTestHexEncodedBytes());
   runTestCase(painterTestCertVerifierJob());
   runTestCase(painterTestProxyConfig());
   runTestCase(painterTestDontStripCookiesURLRequest());
   runTestCase(painterTestStripCookiesURLRequest());
   runTestCase(painterTestDontStripCookiesSPDYSession());
   runTestCase(painterTestStripCookiesSPDYSession());
   runTestCase(painterTestExtraCustomParameter());
   runTestCase(painterTestMissingCustomParameter());
   runTestCase(painterTestSSLVersionFallback());
 
   testDone();
 });
 
 /**
  * Test case for a URLRequest. This includes custom formatting for load flags,
  * request/response HTTP headers, dependent sources, as well as basic
- * indentation and grouping.
+ * indentation and grouping.  Also makes sure that no extra event is logged
+ * for finished sources when there's a logCreationTime.
  */
 function painterTestURLRequest() {
   var testCase = {};
   testCase.tickOffset = '1337911098446';
+  testCase.logCreationTime = 1338864634013;
 
   testCase.logEntries = [
     {
       'phase': EventPhase.PHASE_BEGIN,
       'source': {
         'id': 146,
         'type': EventSourceType.URL_REQUEST
       },
       'time': '953534778',
       'type': EventType.REQUEST_ALIVE
@@ skipping 591 matching lines @@
 't=1338864633998 [st=774]    HTTP_TRANSACTION_READ_BODY  [dt=1]\n' +
 't=1338864633999 [st=775]    HTTP_CACHE_WRITE_DATA  [dt=3]\n' +
 't=1338864634002 [st=778]    HTTP_TRANSACTION_READ_BODY  [dt=3]\n' +
 't=1338864634005 [st=781]    HTTP_CACHE_WRITE_DATA  [dt=0]\n' +
 't=1338864634013 [st=789] -REQUEST_ALIVE';
 
   return testCase;
 }
 
 /**
+ * Test case for a URLRequest that was not completed that did not come from a
+ * loaded log file.
+ */
+function painterTestURLRequestIncomplete() {
+  var testCase = {};
+  testCase.tickOffset = '1337911098446';
+
+  testCase.logEntries = [
+    {
+      'phase': EventPhase.PHASE_BEGIN,
+      'source': {
+        'id': 146,
+        'type': EventSourceType.URL_REQUEST
+      },
+      'time': '953534778',
+      'type': EventType.REQUEST_ALIVE
+    },
+    {
+      'params': {
+        'load_flags': 128,
+        'method': 'GET',
+        'priority': 4,
+        'url': 'http://www.google.com/'
+      },
+      'phase': EventPhase.PHASE_BEGIN,
+      'source': {
+        'id': 146,
+        'type': EventSourceType.URL_REQUEST
+      },
+      'time': '953534910',
+      'type': EventType.URL_REQUEST_START_JOB
+    },
+    {
+      'phase': EventPhase.PHASE_END,
+      'source': {
+        'id': 146,
+        'type': EventSourceType.URL_REQUEST
+      },
+      'time': '953534970',
+      'type': EventType.URL_REQUEST_START_JOB
+    },
+  ];
+
+  testCase.expectedText =
+'t=1338864633224 [st=  0] +REQUEST_ALIVE  [dt=?]\n' +
+'t=1338864633356 [st=132]    URL_REQUEST_START_JOB  [dt=60]\n' +
+'                            --> load_flags = 128 (ENABLE_LOAD_TIMING)\n' +
+'                            --> method = "GET"\n' +
+'                            --> priority = 4\n' +
+'                            --> url = "http://www.google.com/"';
+
+  return testCase;
+}
+
+/**
+ * Test case for a URLRequest that was not completed that came from a loaded
+ * log file.
+ */
+function painterTestURLRequestIncompleteFromLoadedLog() {
+  var testCase = painterTestURLRequestIncomplete();
+  testCase.logCreationTime = 1338864634013;
+  testCase.expectedText =
+      testCase.expectedText.replace('[dt=?]', '[dt=789+]') + '\n' +

[eroman, 2012/07/31 21:53:43]

optional: I think it would be more readable to just duplicate the whole thing.

[mmenke, 2012/07/31 22:53:16]

Done.

+      't=1338864634013 [st=789]';
+  return testCase;
+}
+
+/**
  * Tests the custom formatting of net_errors across several different event
  * types.
  */
 function painterTestNetError() {
   var testCase = {};
   testCase.tickOffset = '1337911098446';
 
   testCase.logEntries = [
      {
        'phase': EventPhase.PHASE_BEGIN,
@@ skipping 528 matching lines @@
   return testCase;
 }
 
 /**
  * Tests that cookies are stripped from URLRequest when stripping is enabled.
  */
 function painterTestStripCookiesURLRequest() {
   var testCase = painterTestDontStripCookiesURLRequest();
   testCase.enableSecurityStripping = true;
   testCase.expectedText =
-    testCase.expectedText.replace(/MyMagicPony/g, '[value was stripped]');
+      testCase.expectedText.replace(/MyMagicPony/g, '[value was stripped]');
   return testCase;
 }
 
 /**
  * Tests that cookies are NOT stripped from SPDY sessions when stripping is not
  * enabled. This test data was pieced together in order to get a "cookie" and
  * "set-cookie" header.
  */
 function painterTestDontStripCookiesSPDYSession() {
   var testCase = {};
@@ skipping 226 matching lines @@
 '                          --> TLS 1.0 ==> SSL 3.0\n' +
 '                          --> host_and_port = "www-927.ibm.com:443"\n' +
 '                          --> net_error = -107 (ERR_SSL_PROTOCOL_ERROR)\n' +
 't=1339030161250 [st=171]  SSL_VERSION_FALLBACK\n' +
 '                          --> SSL 3.0 ==> SSL 0x123456';
 
   return testCase;
 }
 
 })();  // Anonymous namespace