chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc - Issue 10825102: Protect Chrome WebStore based on process IDs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc

Issue 10825102: Protect Chrome WebStore based on process IDs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unit tests Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc » ('j') | chrome/browser/extensions/api/web_request/web_request_permissions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc

index 9301dc0fc76cead8ed89f95bacd95c96a29dbc58..a4c06c7afe134548bb5a7d9d83de119bf378a611 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc

@@ -203,7 +203,7 @@ bool WebRequestAction::HasPermission(const ExtensionInfoMap* extension_info_map,

const std::string& extension_id,

const net::URLRequest* request,

bool crosses_incognito) const {

- if (WebRequestPermissions::HideRequest(request))

+ if (WebRequestPermissions::HideRequest(extension_info_map, request))

return false;

// In unit tests we don't have an extension_info_map object here and skip host