Roll Skia to 4889.

Roll Skia to 4843.

[bungeman-chromium, 2012-07-31 20:02:25]

Roll Skia to 4843.

[bungeman-chromium, 2012-07-31 20:16:22]

On 2012/07/31 20:02:25, bungeman2 wrote:
> Roll Skia to 4843.

Patch set 4 control at http://codereview.chromium.org/10831088/ patch set 2.

[bungeman-chromium, 2012-07-31 22:22:04]

The control for patch set 6 is http://codereview.chromium.org/10831088/ patch
set 2.

Things look ok on Linux and Windows, with no new failures. Mac has no new
failures but does have a large number of failures in both the patch and control
builds due to an inability to find missingImage.png.

[reed1, 2012-08-01 12:41:37]

http://codereview.chromium.org/10825089/diff/9003/skia/skia.gyp
File skia/skia.gyp (right):

http://codereview.chromium.org/10825089/diff/9003/skia/skia.gyp#newcode1082
skia/skia.gyp:1082: '../third_party/skia/include/core',
// THis is a temp hack

[reed1, 2012-08-01 12:42:43]

lgtm

[commit-bot: I haz the power, 2012-08-01 13:39:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bungeman@chromium.org/10825089/9006

[bungeman-chromium, 2012-08-01 16:55:37]

So there was a bug where kGenA8FromLCD_Flag was not taken into account, causing
the debug assert (which was a good assert, as it caught an issue early). This
has now been fixed and everything should work now. The new control (for patch
set 7) is http://codereview.chromium.org/10831088/ patch set 3.

[bungeman-chromium, 2012-08-01 17:32:38]

Now rolling to 4889.

[reed1, 2012-08-01 19:24:46]

lgtm

[reed1, 2012-08-01 19:46:30]

Mirrored in https://chromiumcodereview.appspot.com/10827122
Committed revision 149468.

[bungeman-chromium, 2012-08-02 03:29:14]

Abandoned in favor of https://chromiumcodereview.appspot.com/10850012 which has
an appropriate base url.