Stop using ScopedAllowIO in content::ResourceDispatcherHostImpl

net/url_request/url_request.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_H_
 #define NET_URL_REQUEST_URL_REQUEST_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 217 matching lines @@
   //    - OnReadCompleted* (zero or more calls until all data is read)
   //
   // Read() must be called at least once. Read() returns true when it completed
   // immediately, and false if an IO is pending or if there is an error.  When
   // Read() returns false, the caller can check the Request's status() to see
   // if an error occurred, or if the IO is just pending.  When Read() returns
   // true with zero bytes read, it indicates the end of the response.
   //
   class NET_EXPORT Delegate {
    public:
+    // Called when the request body (upload data) is initialized.
+    virtual void OnRequestBodyInitialized(URLRequest* request, uint64 size);

[darin (slow to review), 2012/08/14 18:24:27]

Does this really need to be an event?  Why not just let the caller poll for the
upload size?  Have a GetUploadSize function that returns -1 or fail if the
upload size is unknown?  I'd also be OK with GetUploadProgress having an out
parameter to report the total size:

  // Returns true if progress has been made uploading data and reports
  // the upload progress and total upload size in bytes.  Otherwise,
  // returns false if there is no upload data or if we haven't begun
  // uploading data yet.
  bool GetUploadProgress(uint64* progress, uint64* total) const;

In other words, since we don't need an edge trigger for when the upload begins,
we could very well do away with the event and just simply provide a polling
interface.

+
     // Called upon a server-initiated redirect.  The delegate may call the
     // request's Cancel method to prevent the redirect from being followed.
     // Since there may be multiple chained redirects, there may also be more
     // than one redirect call.
     //
     // When this function is called, the request will still contain the
     // original URL, the destination of the redirect is provided in 'new_url'.
     // If the delegate does not cancel the request and |*defer_redirect| is
     // false, then the redirect will be followed, and the request's URL will be
     // changed to the new URL.  Otherwise if the delegate does not cancel the
@@ skipping 383 matching lines @@
 
   // TODO(willchan): Undo this. Only temporarily public.
   bool has_delegate() const { return delegate_ != NULL; }
 
   // NOTE(willchan): This is just temporary for debugging
   // http://crbug.com/90971.
   // Allows to setting debug info into the URLRequest.
   void set_stack_trace(const base::debug::StackTrace& stack_trace);
   const base::debug::StackTrace* stack_trace() const;
 
+  // Called by HttpNetworkTransaction when the request body is initialized.
+  void NotifyRequestBodyInitialized(uint64 size);
+
  protected:
   // Allow the URLRequestJob class to control the is_pending() flag.
   void set_is_pending(bool value) { is_pending_ = value; }
 
   // Allow the URLRequestJob class to set our status too
   void set_status(const URLRequestStatus& value) { status_ = value; }
 
   // Allow the URLRequestJob to redirect this request.  Returns OK if
   // successful, otherwise an error code is returned.
   int Redirect(const GURL& location, int http_status_code);
@@ skipping 165 matching lines @@
   base::TimeTicks creation_time_;
 
   scoped_ptr<const base::debug::StackTrace> stack_trace_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequest);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_H_