chrome/common/extensions/docs/server2/templates/private/samples.html - Issue 10825067: Extensions Docs Server: Apps samples page

Side by Side Diff: chrome/common/extensions/docs/server2/templates/private/samples.html

Issue 10825067: Extensions Docs Server: Apps samples page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixes Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/extensions/docs/server2/templates/private/sample_item.html ('K') | « chrome/common/extensions/docs/server2/templates/private/sample_item.html ('k') | chrome/common/extensions/docs/server2/templates/private/standard_apps_api.html » ('j') | chrome/common/extensions/docs/server2/templates/private/standard_apps_api.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 {{+partials.header_head}}

	5 <link href="{{static}}/css/samples.css" rel="stylesheet" type="text/css">

	6 </head>

	7 <body>

	8 {{+partials.header_body}}

	9 <div id="gc-container">
	not at google - send to devlin 2012/08/10 06:02:18 So, we should only use is_apps if absolutely neces So, we should only use is_apps if absolutely necessary. Using is_apps makes the templates less reusable, generally harder to follow. Instead, inject - the sidenav - the title (I will definitely try to write that patch, though if I don't you can always define "apps_title" and "extensions_title" like you did for true/false in the dict generator). - the API list - the samples - the footer At this point you might want to document this template like you would a function, with a comment at the top explaining what the parameters are. cduvall 2012/08/10 21:17:47 Done. Show quoted text On 2012/08/10 06:02:18, kalman wrote: > So, we should only use is_apps if absolutely necessary. Using is_apps makes the > templates less reusable, generally harder to follow. > > Instead, inject > - the sidenav > - the title (I will definitely try to write that patch, though if I don't you > can always define "apps_title" and "extensions_title" like you did for > true/false in the dict generator). > - the API list > - the samples > - the footer > > At this point you might want to document this template like you would a > function, with a comment at the top explaining what the parameters are. Done.
	10 {{?is_apps}}

	11 {{+partials.apps_sidenav}}

	12 {{:is_apps}}

	13 {{+partials.extensions_sidenav}}

	14 {{/is_apps}}

	15 <div id="gc-pagecontent">

	16 <h1 class="page_title">Sample {{?is_apps}}Apps{{:}}Extensions{{/}}</h1>

	17 <div id="controls">

	18 <table class="controlbox">

	19 <tr>

	20 <td class="label">Filter by keyword:</td>

	21 <td><input autofocus type="search" id="search_input" placeholder=" Type to search"></td>

	22 </tr>

	23 <tr>

	24 <td class="label">Filter by API:</td>

	25 <td>

	26 <div id="api_filter_items">

	27 {{?is_apps}}

	28 {{#api_list.apps.chrome}}{{+partials.filter_item}}{{/}}

	29 {{:is_apps}}

	30 {{#api_list.extensions.chrome}}{{+partials.filter_item}}{{/}}

	31 {{/is_apps}}

	32 </div>

	33 </td>

	34 </tr>

	35 </table>

	36 </div>

	37 {{?is_apps}}

	38 {{#samples.apps}}

	39 {{+partials.sample_item is_apps:true}}

	40 {{/samples.apps}}

	41 {{:is_apps}}

	42 {{#samples.extensions}}

	43 {{+partials.sample_item is_apps:false}}

	44 {{/samples.extensions}}

	45 {{/is_apps}}

	46 </div>

	47 </div>

	48 </body>

	49 {{+partials.footer is_apps:is_apps}}
	not at google - send to devlin 2012/08/10 06:02:18 The only difference in the footer is the bootstrap The only difference in the footer is the bootstrapped samples JSON. We used to do this in a separate <script> tag before including the footer; perhaps we should have apps_footer and extensions_footer which does this (each would set up the right bootstrap arguments, then call the generic footer thing). cduvall 2012/08/10 21:17:47 Done. Show quoted text On 2012/08/10 06:02:18, kalman wrote: > The only difference in the footer is the bootstrapped samples JSON. We used to > do this in a separate <script> tag before including the footer; perhaps we > should have apps_footer and extensions_footer which does this (each would set up > the right bootstrap arguments, then call the generic footer thing). Done.
	50 <script src="{{static}}/js/samples.js" type="text/javascript"></script>

	51 </html>

OLD	NEW