Implement media path filter

chrome/browser/intents/device_attached_intent_source.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/intents/device_attached_intent_source.h"
 
 #include "base/file_path.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
@@ skipping 36 matching lines @@
   const FilePath device_path(location);
   if (!device_path.IsAbsolute() || device_path.ReferencesParent())
     return;
 
   std::string device_name;
 
   // Register device path as an isolated file system.
   // TODO(kinuko, kmadhusu): Use a different file system type for MTP.
   const std::string filesystem_id =
       fileapi::IsolatedContext::GetInstance()->RegisterFileSystemForPath(
-          fileapi::kFileSystemTypeIsolated, device_path, &device_name);
+          fileapi::kFileSystemTypeLocalMedia, device_path, &device_name);

[kmadhusu, 2012/07/26 20:26:43]

This is a file system for attached device media. Can we call this as
kFileSystemTypeDeviceMedia?

[tzik, 2012/07/27 01:00:23]

Hmm. We might have two type of media device.
One is mounted device to which we can access like local filesystem (this case).
Another is the device that we need to use MTP or PTP.

How about using kFileSystemTypeMountedMedia?

[kmadhusu, 2012/07/27 01:22:42]

I thought kFileSystemTypeLocalMedia corresponds to local media galleries such as
"C:\MyPictures\" etc.  I guess you are considering mass storage devices (such as
usb, external hard drive) and local media galleries("C:\MyPictures\") as
"kFileSystemTypeLocalMedia" and mtp/ptp device galleries as
"kFileSystemTypeDeviceMedia". Is it correct? If so, we need a better name for
file system types.

[tzik, 2012/07/27 18:33:22]

Yes, I mean that exactly. As we chatted, s/LocalMedia/NativeMedia/ looks good.

 
   CHECK(!filesystem_id.empty());
   webkit_glue::WebIntentData intent(
       ASCIIToUTF16("chrome-extension://attach"),
       ASCIIToUTF16("chrome-extension://filesystem"),
       device_name,
       filesystem_id);
 
   delegate_->WebIntentDispatch(NULL  /* no WebContents */,
                                content::WebIntentsDispatcher::Create(intent));
 }