Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: ash/shell.cc

Issue 10825026: Make accelerators not to work when the keyboard overlay is shown. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shell.h" 5 #include "ash/shell.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "ash/accelerators/focus_manager_factory.h" 10 #include "ash/accelerators/focus_manager_factory.h"
(...skipping 23 matching lines...) Expand all
34 #include "ash/touch/touch_observer_hud.h" 34 #include "ash/touch/touch_observer_hud.h"
35 #include "ash/wm/activation_controller.h" 35 #include "ash/wm/activation_controller.h"
36 #include "ash/wm/always_on_top_controller.h" 36 #include "ash/wm/always_on_top_controller.h"
37 #include "ash/wm/app_list_controller.h" 37 #include "ash/wm/app_list_controller.h"
38 #include "ash/wm/base_layout_manager.h" 38 #include "ash/wm/base_layout_manager.h"
39 #include "ash/wm/capture_controller.h" 39 #include "ash/wm/capture_controller.h"
40 #include "ash/wm/custom_frame_view_ash.h" 40 #include "ash/wm/custom_frame_view_ash.h"
41 #include "ash/wm/dialog_frame_view.h" 41 #include "ash/wm/dialog_frame_view.h"
42 #include "ash/wm/event_client_impl.h" 42 #include "ash/wm/event_client_impl.h"
43 #include "ash/wm/event_rewriter_event_filter.h" 43 #include "ash/wm/event_rewriter_event_filter.h"
44 #include "ash/wm/overlay_event_filter.h"
44 #include "ash/wm/panel_layout_manager.h" 45 #include "ash/wm/panel_layout_manager.h"
45 #include "ash/wm/panel_window_event_filter.h" 46 #include "ash/wm/panel_window_event_filter.h"
46 #include "ash/wm/partial_screenshot_event_filter.h"
47 #include "ash/wm/power_button_controller.h" 47 #include "ash/wm/power_button_controller.h"
48 #include "ash/wm/resize_shadow_controller.h" 48 #include "ash/wm/resize_shadow_controller.h"
49 #include "ash/wm/root_window_layout_manager.h" 49 #include "ash/wm/root_window_layout_manager.h"
50 #include "ash/wm/screen_dimmer.h" 50 #include "ash/wm/screen_dimmer.h"
51 #include "ash/wm/shadow_controller.h" 51 #include "ash/wm/shadow_controller.h"
52 #include "ash/wm/shelf_layout_manager.h" 52 #include "ash/wm/shelf_layout_manager.h"
53 #include "ash/wm/stacking_controller.h" 53 #include "ash/wm/stacking_controller.h"
54 #include "ash/wm/status_area_layout_manager.h" 54 #include "ash/wm/status_area_layout_manager.h"
55 #include "ash/wm/system_gesture_event_filter.h" 55 #include "ash/wm/system_gesture_event_filter.h"
56 #include "ash/wm/system_modal_container_layout_manager.h" 56 #include "ash/wm/system_modal_container_layout_manager.h"
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 // effects (e.g. crashes) from changing focus during shutdown. 203 // effects (e.g. crashes) from changing focus during shutdown.
204 // See bug crbug.com/134502. 204 // See bug crbug.com/134502.
205 if (active_root_window_) 205 if (active_root_window_)
206 active_root_window_->GetFocusManager()->SetFocusedWindow(NULL, NULL); 206 active_root_window_->GetFocusManager()->SetFocusedWindow(NULL, NULL);
207 207
208 aura::Env::GetInstance()->cursor_manager()->set_delegate(NULL); 208 aura::Env::GetInstance()->cursor_manager()->set_delegate(NULL);
209 209
210 // Please keep in same order as in Init() because it's easy to miss one. 210 // Please keep in same order as in Init() because it's easy to miss one.
211 RemoveEnvEventFilter(user_activity_detector_.get()); 211 RemoveEnvEventFilter(user_activity_detector_.get());
212 RemoveEnvEventFilter(event_rewriter_filter_.get()); 212 RemoveEnvEventFilter(event_rewriter_filter_.get());
213 RemoveEnvEventFilter(partial_screenshot_filter_.get()); 213 RemoveEnvEventFilter(overlay_filter_.get());
214 RemoveEnvEventFilter(input_method_filter_.get()); 214 RemoveEnvEventFilter(input_method_filter_.get());
215 RemoveEnvEventFilter(window_modality_controller_.get()); 215 RemoveEnvEventFilter(window_modality_controller_.get());
216 if (mouse_cursor_filter_.get()) 216 if (mouse_cursor_filter_.get())
217 RemoveEnvEventFilter(mouse_cursor_filter_.get()); 217 RemoveEnvEventFilter(mouse_cursor_filter_.get());
218 RemoveEnvEventFilter(system_gesture_filter_.get()); 218 RemoveEnvEventFilter(system_gesture_filter_.get());
219 #if !defined(OS_MACOSX) 219 #if !defined(OS_MACOSX)
220 RemoveEnvEventFilter(accelerator_filter_.get()); 220 RemoveEnvEventFilter(accelerator_filter_.get());
221 #endif 221 #endif
222 if (touch_observer_hud_.get()) 222 if (touch_observer_hud_.get())
223 RemoveEnvEventFilter(touch_observer_hud_.get()); 223 RemoveEnvEventFilter(touch_observer_hud_.get());
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 // The order in which event filters are added is significant. 393 // The order in which event filters are added is significant.
394 DCHECK(!GetEnvEventFilterCount()); 394 DCHECK(!GetEnvEventFilterCount());
395 user_activity_detector_.reset(new UserActivityDetector); 395 user_activity_detector_.reset(new UserActivityDetector);
396 AddEnvEventFilter(user_activity_detector_.get()); 396 AddEnvEventFilter(user_activity_detector_.get());
397 397
398 DCHECK_EQ(1U, GetEnvEventFilterCount()); 398 DCHECK_EQ(1U, GetEnvEventFilterCount());
399 event_rewriter_filter_.reset(new internal::EventRewriterEventFilter); 399 event_rewriter_filter_.reset(new internal::EventRewriterEventFilter);
400 AddEnvEventFilter(event_rewriter_filter_.get()); 400 AddEnvEventFilter(event_rewriter_filter_.get());
401 401
402 DCHECK_EQ(2U, GetEnvEventFilterCount()); 402 DCHECK_EQ(2U, GetEnvEventFilterCount());
403 partial_screenshot_filter_.reset(new internal::PartialScreenshotEventFilter); 403 overlay_filter_.reset(new internal::OverlayEventFilter);
404 AddEnvEventFilter(partial_screenshot_filter_.get()); 404 AddEnvEventFilter(overlay_filter_.get());
405 AddShellObserver(partial_screenshot_filter_.get()); 405 AddShellObserver(overlay_filter_.get());
406 406
407 DCHECK_EQ(3U, GetEnvEventFilterCount()); 407 DCHECK_EQ(3U, GetEnvEventFilterCount());
408 input_method_filter_.reset(new aura::shared::InputMethodEventFilter()); 408 input_method_filter_.reset(new aura::shared::InputMethodEventFilter());
409 AddEnvEventFilter(input_method_filter_.get()); 409 AddEnvEventFilter(input_method_filter_.get());
410 410
411 #if !defined(OS_MACOSX) 411 #if !defined(OS_MACOSX)
412 accelerator_filter_.reset(new internal::AcceleratorFilter); 412 accelerator_filter_.reset(new internal::AcceleratorFilter);
413 AddEnvEventFilter(accelerator_filter_.get()); 413 AddEnvEventFilter(accelerator_filter_.get());
414 #endif 414 #endif
415 415
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
782 } 782 }
783 783
784 void Shell::ShowCursor(bool visible) { 784 void Shell::ShowCursor(bool visible) {
785 RootWindowList root_windows = GetAllRootWindows(); 785 RootWindowList root_windows = GetAllRootWindows();
786 for (RootWindowList::iterator iter = root_windows.begin(); 786 for (RootWindowList::iterator iter = root_windows.begin();
787 iter != root_windows.end(); ++iter) 787 iter != root_windows.end(); ++iter)
788 (*iter)->ShowCursor(visible); 788 (*iter)->ShowCursor(visible);
789 } 789 }
790 790
791 } // namespace ash 791 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698