Issue 10825010: Run_test_case.py now returns 1 when at least 1 test fails.

Issue 10825010: Run_test_case.py now returns 1 when at least 1 test fails. (Closed)

Created:
8 years, 5 months ago by csharp

Modified:
8 years, 5 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Run_test_case.py now returns 1 when at least 1 test fails. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148366

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -146 lines)			Patch
D	tools/isolate/data/gtest_fake/gtest_fake.py	View		1 chunk	+0 lines, -84 lines	0 comments	Download
A	tools/isolate/data/gtest_fake/gtest_fake_base.py	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
A +	tools/isolate/data/gtest_fake/gtest_fake_fail.py	View	1	4 chunks	+7 lines, -34 lines	0 comments	Download
A	tools/isolate/data/gtest_fake/gtest_fake_pass.py	View	1	1 chunk	+55 lines, -0 lines	0 comments	Download
M	tools/isolate/run_test_cases.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/isolate/run_test_cases_smoke_test.py	View	1	4 chunks	+54 lines, -24 lines	0 comments	Download
M	tools/isolate/trace_test_cases_smoke_test.py	View	1	3 chunks	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Thanks, I had realized but hadn't taken the time to fix that yet. lgtm http://codereview.chromium.org/10825010/diff/2001/tools/isolate/data/gtest_fake/gtest_fake_base.py ...

8 years, 5 months ago (2012-07-25 16:03:19 UTC) #2

csharp

https://chromiumcodereview.appspot.com/10825010/diff/2001/tools/isolate/data/gtest_fake/gtest_fake_base.py File tools/isolate/data/gtest_fake/gtest_fake_base.py (right): https://chromiumcodereview.appspot.com/10825010/diff/2001/tools/isolate/data/gtest_fake/gtest_fake_base.py#newcode1 tools/isolate/data/gtest_fake/gtest_fake_base.py:1: #!/usr/bin/env python On 2012/07/25 16:03:20, Marc-Antoine Ruel wrote: > ...

8 years, 5 months ago (2012-07-25 16:55:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10825010/7002

8 years, 5 months ago (2012-07-25 16:55:44 UTC) #4

Change committed as 148366

Expand Messages | Collapse Messages